Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8340437: Open source few more AWT Frame related tests #21199

Closed
wants to merge 2 commits into from
Closed

8340437: Open source few more AWT Frame related tests #21199

wants to merge 2 commits into from

Conversation

kumarabhi006
Copy link
Contributor

@kumarabhi006 kumarabhi006 commented Sep 26, 2024 •
edited by openjdk bot
Loading

AWT Frame related tests are converted from applet to manual/automated and moved to open.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340437: Open source few more AWT Frame related tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21199/head:pull/21199
$ git checkout pull/21199

Update a local copy of the PR:
$ git checkout pull/21199
$ git pull https://git.openjdk.org/jdk.git pull/21199/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21199

View PR using the GUI difftool:
$ git pr show -t 21199

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21199.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 26, 2024

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 26, 2024 •
edited
Loading

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340437: Open source few more AWT Frame related tests

Reviewed-by: prr, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 26, 2024
@openjdk
Copy link

openjdk bot commented Sep 26, 2024

@kumarabhi006 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 26, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 26, 2024 •
edited
Loading

Webrevs

azuev-java
azuev-java approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@azuev-java azuev-java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 26, 2024
prrace
prrace reviewed Sep 29, 2024
View reviewed changes
test/jdk/java/awt/Frame/MultiScreenTest.java
if (gs.length < 2) {
throw new SkippedException("You have only one monitor in your system - test passed");
}
MultiScreenTest obj = new MultiScreenTest();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this test will bail if there aren't two monitors, I'd like to see us remember to add @key multimon to such tests.
Then if someone wants to run multimon testsand ONLY those tests they can specify this key
I'm sure we missed a couple of opportunities to do it already but let's not miss this one.

See
https://github.com/openjdk/jdk/blob/master/test/jdk/TEST.ROOT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.. added @key multimon.

prrace
prrace reviewed Sep 29, 2024
View reviewed changes
test/jdk/java/awt/Frame/IMStatusBar.java
public static void main(String[] args) throws Exception {
String INSTRUCTIONS = """
If the window appears the right size, but then resizes so that the
status field overlaps the bottom label, press Fail; otherwise press Pass.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this ALWAYS bring up an IM window ? On all platforms.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked on all platforms (Win, Linux and Mac), IM window always shown.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Sep 30, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 30, 2024
@kumarabhi006
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

Going to push as commit 9bd4785.
Since your change was applied there have been 100 commits pushed to the master branch:

  • 988f13a: 8340354: Open source AWT desktop properties and print related tests
  • b11066b: 8340719: Open source AWT List tests
  • a32c3b4: 8340407: Open source a few more Component related tests
  • 31858fc: 8340491: Thread stack-base assertion should report which thread has the un-set stack
  • bfdeb33: 8340332: Open source mixed AWT tests - Set3
  • a6b3188: 8337632: AES-GCM Algorithm optimization for x86_64
  • 5586f83: 8341064: Define anchor point and index term for "wrapper classes"
  • 4168faf: 8341100: Add index entries for terms used in java.lang.Class
  • f1bf469: 8341199: Use ClassFile's new API loadConstant(int)
  • 860d49d: 8211400: nsk.share.gc.Memory::getArrayLength returns wrong value
  • ... and 90 more: https://git.openjdk.org/jdk/compare/4098acc200e608369ac1631dcc8513ea797bd59e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 1, 2024
@openjdk openjdk bot closed this Oct 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 1, 2024
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@kumarabhi006 Pushed as commit 9bd4785.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prrace prrace prrace approved these changes

@azuev-java azuev-java azuev-java approved these changes

Assignees
No one assigned
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumarabhi006 @prrace @azuev-java