8339637: (tz) Update Timezone Data to 2024b #21265

johnyjose30 · 2024-09-30T14:03:15Z

Timezone data 2024b changes

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Change requires CSR request JDK-8340138 to be approved
Commit message must refer to an issue

Issues

JDK-8339637: (tz) Update Timezone Data to 2024b (Enhancement - P3)
JDK-8340138: (tz) Update Timezone Data to 2024b (CSR)

Reviewers

Justin Lu (@justin-curtis-lu - Committer) Review applies to b3a092c3
Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21265/head:pull/21265
$ git checkout pull/21265

Update a local copy of the PR:
$ git checkout pull/21265
$ git pull https://git.openjdk.org/jdk.git pull/21265/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21265

View PR using the GUI difftool:
$ git pr show -t 21265

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21265.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-09-30T14:04:01Z

👋 Welcome back johnyjose30! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

johnyjose30 · 2024-09-30T14:05:11Z

/reviewer credit @coffeys @naotoj

openjdk · 2024-09-30T14:05:17Z

@johnyjose30 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339637: (tz) Update Timezone Data to 2024b

Reviewed-by: naoto, coffeys, jlu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 310 new commits pushed to the master branch:

6d7e679: 8340790: Open source several AWT Dialog tests - Batch 4
86ce19e: 8341142: Maintain a single source file for sun.net.www.protocol.jar.JarFileFactory
b9cabbe: 8341997: Tests create files in src tree instead of scratch dir
5eae20f: 8323672: Suppress unwanted autoconf added flags in CC and CXX
6ed6dff: 8341871: Disable G1 for unsupported platforms after JDK-8334060
54c9348: 8336103: Clean up confusing Method::is_initializer
2c0c653: 8342044: Increase timeout of gc/shenandoah/oom/TestClassLoaderLeak.java
df7d6e0: 8338603: DiagnosticCommandMBean operations should standardize types for parameters
c9a536c: 8337339: gc/arguments/Test*SizeFlags.java timing out with Xcomp
f4dccfd: 8338596: Clarify handling of restricted and caller-sensitive methods
... and 300 more: https://git.openjdk.org/jdk/compare/44024826e52373d1613ec366e3f5a9d5bbaefa41...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@justin-curtis-lu, @naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2024-09-30T14:06:11Z

@johnyjose30
Reviewer coffeys successfully credited.

Reviewer naoto successfully credited.

openjdk · 2024-09-30T14:07:03Z

@johnyjose30 The following labels will be automatically applied to this pull request:

core-libs
i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-09-30T14:09:49Z

Webrevs

justin-curtis-lu · 2024-10-01T18:16:56Z

src/java.base/share/classes/java/time/ZoneId.java

     * later, where 'EST', 'MST' and 'HST' map to IDs which do not include daylight
-     * savings.
+     * savings since 1970.


Hi Johny, the future flexibility clause seems to be missing in the spec update of ZoneId.

Thanks for the changes in c323844.

Can we also add the following to the ZoneId specification,

Suggested change

* savings since 1970.

* savings since 1970. This mapping may change in update releases in support of new versions of TZDB.

justin-curtis-lu · 2024-10-01T18:29:20Z

src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java

        }
+        aliases.put("HST", "Pacific/Honolulu");


Looks correct to me, since "HST" to "Pacific/Honolulu" link is same for USE_OLDMAPPING as well as 2024b update.

justin-curtis-lu · 2024-10-01T18:30:24Z

src/java.base/share/classes/java/time/ZoneId.java

@@ -186,15 +186,12 @@ public abstract sealed class ZoneId implements Serializable permits ZoneOffset,
     * This map allows the IDs to continue to be used via the
     * {@link #of(String, Map)} factory method.
     * <p>
-     * This map contains a mapping of the IDs that is in line with TZDB 2005r and


I believe this file needs a copyright year bump.

justin-curtis-lu · 2024-10-01T18:31:27Z

test/jdk/sun/util/resources/TimeZone/Bug4848242.java

@@ -35,7 +35,6 @@
 public class Bug4848242 {


This test needs a copyright year bump. (Applies to any other tests as well).

We also might want to update the summary, since it should no longer display MET and MEST, but rather CET and CEST.

justin-curtis-lu · 2024-10-01T18:40:56Z

test/jdk/sun/util/calendar/zi/TestZoneInfo310.java


+        if (l1.equals(l2)) {
+            System.out.println("no diff");


Is this needed? IIUC diff is only called if the array contents are not equal.

Since diff is a generic debug function, equality check needed to be in the function itself. Anyway, I wrote this code for purely debug purpose, so can be removed altogether.

justin-curtis-lu

Besides small comment, looks correct to me, thanks for the changes.

justin-curtis-lu · 2024-10-13T04:10:52Z

test/jdk/sun/util/calendar/zi/TestZoneInfo310.java

@@ -279,6 +279,4 @@ private static ZoneInfoOld toZoneInfoOld(TimeZone tz) throws Exception {
                               (int[])simpleTimeZoneParams.get(tz),
                               willGMTOffsetChange.getBoolean(tz));
    }
-


Patch will be cleaner if we remove the line change (L 282-283) as well.

naotoj

LGTM

johnyjose30 · 2024-10-16T06:29:12Z

/integrate

openjdk · 2024-10-16T06:30:01Z

@johnyjose30
Your change (at version a6aac06) is now ready to be sponsored by a Committer.

coffeys · 2024-10-16T07:35:24Z

/sponsor

openjdk · 2024-10-16T07:36:09Z

Going to push as commit ebc17c7.
Since your change was applied there have been 316 commits pushed to the master branch:

e7cf25c: 8340801: Disable ubsan checks in some awt/2d coding
577babf: 8334010: VM crashes with ObjectAlignmentInBytes > GCCardSizeInBytes
b9b0bd0: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing
724de68: 8342081: Shenandoah: Remove extra ShenandoahMarkUpdateRefsSuperClosure
e4ff553: 8341931: os_linux gtest uses lambdas with explicit capture lists
e94e3bb: 8324672: Update jdk/java/time/tck/java/time/TCKInstant.java now() to be more robust
6d7e679: 8340790: Open source several AWT Dialog tests - Batch 4
86ce19e: 8341142: Maintain a single source file for sun.net.www.protocol.jar.JarFileFactory
b9cabbe: 8341997: Tests create files in src tree instead of scratch dir
5eae20f: 8323672: Suppress unwanted autoconf added flags in CC and CXX
... and 306 more: https://git.openjdk.org/jdk/compare/44024826e52373d1613ec366e3f5a9d5bbaefa41...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-10-16T07:36:20Z

@coffeys @johnyjose30 Pushed as commit ebc17c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8339637: (tz) Update Timezone Data to 2024b

6c4ce6f

openjdk bot added the rfr Pull request is ready for review label Sep 30, 2024

openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Sep 30, 2024

justin-curtis-lu reviewed Oct 1, 2024

View reviewed changes

johnyjose30 added 2 commits October 8, 2024 05:22

Review changes

c323844

Review changes

b3a092c

justin-curtis-lu approved these changes Oct 13, 2024

View reviewed changes

Review changes

a6aac06

naotoj approved these changes Oct 14, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 14, 2024

openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 16, 2024

openjdk bot added the integrated Pull request has been integrated label Oct 16, 2024

openjdk bot closed this Oct 16, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8339637: (tz) Update Timezone Data to 2024b #21265

8339637: (tz) Update Timezone Data to 2024b #21265

johnyjose30 commented Sep 30, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 30, 2024

johnyjose30 commented Sep 30, 2024

openjdk bot commented Sep 30, 2024 •

edited

Loading

openjdk bot commented Sep 30, 2024

openjdk bot commented Sep 30, 2024

mlbridge bot commented Sep 30, 2024 •

edited

Loading

justin-curtis-lu Oct 1, 2024

justin-curtis-lu Oct 8, 2024

justin-curtis-lu Oct 1, 2024

justin-curtis-lu Oct 1, 2024

justin-curtis-lu Oct 1, 2024

justin-curtis-lu Oct 1, 2024

naotoj Oct 8, 2024

justin-curtis-lu left a comment

justin-curtis-lu Oct 13, 2024

naotoj left a comment

johnyjose30 commented Oct 16, 2024

openjdk bot commented Oct 16, 2024

coffeys commented Oct 16, 2024

openjdk bot commented Oct 16, 2024

openjdk bot commented Oct 16, 2024

	* savings since 1970.
	* savings since 1970. This mapping may change in update releases in support of new versions of TZDB.

8339637: (tz) Update Timezone Data to 2024b #21265

8339637: (tz) Update Timezone Data to 2024b #21265

Conversation

johnyjose30 commented Sep 30, 2024 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Sep 30, 2024

johnyjose30 commented Sep 30, 2024

openjdk bot commented Sep 30, 2024 • edited Loading

openjdk bot commented Sep 30, 2024

openjdk bot commented Sep 30, 2024

mlbridge bot commented Sep 30, 2024 • edited Loading

Webrevs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justin-curtis-lu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naotoj left a comment

Choose a reason for hiding this comment

johnyjose30 commented Oct 16, 2024

openjdk bot commented Oct 16, 2024

coffeys commented Oct 16, 2024

openjdk bot commented Oct 16, 2024

openjdk bot commented Oct 16, 2024

johnyjose30 commented Sep 30, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Sep 30, 2024 •

edited

Loading

mlbridge bot commented Sep 30, 2024 •

edited

Loading