8344259: Annotate Float16 with jdk.internal.ValueBased

[PaulSandoz]

Annotate Float16 with jdk.internal.ValueBased. This requires we export the package jdk.internal in module java.base to module jdk.incubator.vector.

Doing so enables the compiler and runtime to report warnings about improper attempts to synchronize on instances of Float16, as described in JEP 390.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8344259: Annotate Float16 with jdk.internal.ValueBased (Enhancement - P4)

Reviewers

• Chen Liang (@liach - Reviewer)
• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22128/head:pull/22128
$ git checkout pull/22128

Update a local copy of the PR:
$ git checkout pull/22128
$ git pull https://git.openjdk.org/jdk.git pull/22128/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22128

View PR using the GUI difftool:
$ git pr show -t 22128

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22128.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@PaulSandoz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344259: Annotate Float16 with jdk.internal.ValueBased

Reviewed-by: liach, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@PaulSandoz The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (52ffdce1)

[liach]

Makes sense. Also good simplification of factory call with existing static imports.

[jddarcy]

Looks fine; please manually verify the expected javac warnings are given for misuse of Float16 in non-value ways.

[PaulSandoz]

Looks fine; please manually verify the expected javac warnings are given for misuse of Float16 in non-value ways.

I manually and successfully tested compilation and execution of source that synchronized on an instance of Float16.

[PaulSandoz]

/integrate

[openjdk]

Going to push as commit 1866c0c.
Since your change was applied there have been 18 commits pushed to the master branch:

• 0b9b82a: 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io
• 3c38ed4: 8344314: Revert removal of jdk.internal.java.PreviewFeature.CLASSFILE_API
• 40a055e: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration
• 84ffb64: 8334714: Implement JEP 484: Class-File API
• 6cdebf0: 8343599: Kmem limit and max values swapped when printing container information
• a672138: 8344161: Argument type mismatch for jfr_type_id
• 3245f56: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java
• 5e27608: 8344188: Cleanup sun.net.www.protocol.jar.JarFileFactory after JEP 486 integration
• ba39321: 8343881: java.lang.classfile.Attribute attributeName() method should return Utf8Entry
• 75c651f: 8327156: Avoid copying in StringTable::intern(oop, TRAPS)
• ... and 8 more: https://git.openjdk.org/jdk/compare/db56266ad164b4ecae59451dc0a832097dbfbd8e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@PaulSandoz Pushed as commit 1866c0c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.