8346603: Cleanup Metacity.ThemeGetter class

[turbanoff]

There is opportunity to remove redundant nested class Metacity.ThemeGetter. It was introduced in the SecurityManager era to handle privileged call. Now (after https://github.com/openjdk/jdk/pull/22186/files#diff-5e3ecade1f409333dfba477b64039f86887d1febbff517407835fcac17a77b2a) it's not the case and we can remove it.
It simplifies and streamlines logic.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8346603: Cleanup Metacity.ThemeGetter class (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22292/head:pull/22292
$ git checkout pull/22292

Update a local copy of the PR:
$ git checkout pull/22292
$ git pull https://git.openjdk.org/jdk.git pull/22292/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22292

View PR using the GUI difftool:
$ git pr show -t 22292

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22292.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[bridgekeeper]

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mlbridge]

Webrevs

• 00: Full (02236e3a)

[prrace]

I don't know off the top of my head exactly what should be done here, but it seems odd to refactor obsolete code.
A much more interesting task here would be to figure out if this code is even needed anymore.
Metcity and gconf are SFAIK obsolete and probably this code should have been deleted when we removed gnome 2 support.
You'll need to identify which Linux desktops versions still support this and how they interacts with GTK 3 .. if there's no overlap, then probably this code is never called. In which case it can be removed.

And I am curious how you tested the change ?
You should probably start by instrumenting it to see if it is called in your testing.

[bridgekeeper]

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@turbanoff This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.