Panamize KQueue and EPoll selector implementations #22307
Conversation
|
👋 Welcome back aefimov! A progress list of the required criteria for merging this PR into |
|
/contributor add dclarke |
|
❗ This change is not yet ready to be integrated. |
|
@AlekseiEfimov |
|
@AlekseiEfimov The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
| try (Arena arena = Arena.ofConfined()) { | ||
| MemorySegment epoll_eventMS = arena.allocate(epoll_event.layout()); | ||
|
|
||
| epoll_event.events(epoll_eventMS, events); |
There was a problem hiding this comment.
There is a common pattern here;
- Create an Arena
- allocate a segment for errno
- do stuff
- depending on the returned int, do other stuff
- return a value (or throw)
Could we consolidate that logic in a reusable method?
There was a problem hiding this comment.
I think thats a good idea, I'll look into it
|
It's so nice to say goodbye to the C files. |
| * } | ||
| */ | ||
| @SuppressWarnings("restricted") | ||
| public class epoll_data { |
There was a problem hiding this comment.
These classes could be final and have a private constructor.
Description of the changes is under construction
Progress
Contributors
<dclarke@openjdk.org>Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22307/head:pull/22307$ git checkout pull/22307Update a local copy of the PR:
$ git checkout pull/22307$ git pull https://git.openjdk.org/jdk.git pull/22307/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22307View PR using the GUI difftool:
$ git pr show -t 22307Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22307.diff