Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346143: add ClearAllFramePops function to speedup debugger single stepping in some cases #22744

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sspitsyn
Copy link
Contributor

@sspitsyn sspitsyn commented Dec 13, 2024

New JVMTI function ClearAllFramePops will help to speedup debugger single stepping in some cases.
Additionally, the JVMTI NotifyFramePop implementation was fixed to return JVMTI_ERROR_DUPLICATE to make it consistent with the SetBreakpoint which also returns this error.

The JDWP agent fix will be needed to make use of this new JVMTI function. The corresponding debugger bug is:
8229012: When single stepping, the debug agent can cause the thread to remain in interpreter mode after single stepping completes

CSR: 8346144: add ClearAllFramePops function to speedup debugger single stepping in some cases

Testing:

  • mach5 tiers 1-6 were run to make sure this fix caused no regressions
  • Chris tested the JVMTI patch with his JDWP fix of 8229012.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8346144 to be approved

Warning

 ⚠️ Found leading lowercase letter in issue title for 8346143: add ClearAllFramePops function to speedup debugger single stepping in some cases

Issues

  • JDK-8346143: add ClearAllFramePops function to speedup debugger single stepping in some cases (Enhancement - P4)
  • JDK-8346144: add ClearAllFramePops function to speedup debugger single stepping in some cases (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22744/head:pull/22744
$ git checkout pull/22744

Update a local copy of the PR:
$ git checkout pull/22744
$ git pull https://git.openjdk.org/jdk.git pull/22744/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22744

View PR using the GUI difftool:
$ git pr show -t 22744

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22744.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2024

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Dec 13, 2024
@openjdk
Copy link

openjdk bot commented Dec 13, 2024

@sspitsyn The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Dec 13, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 13, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2024

Webrevs

@plummercj
Copy link
Contributor

Are you going to add a test case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csr Pull request needs approved CSR before integration hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants