8346143: add ClearAllFramePops function to speedup debugger single stepping in some cases #22744
+129
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New JVMTI function
ClearAllFramePops
will help to speedup debugger single stepping in some cases.Additionally, the JVMTI
NotifyFramePop
implementation was fixed to returnJVMTI_ERROR_DUPLICATE
to make it consistent with theSetBreakpoint
which also returns this error.The JDWP agent fix will be needed to make use of this new JVMTI function. The corresponding debugger bug is:
8229012: When single stepping, the debug agent can cause the thread to remain in interpreter mode after single stepping completes
CSR: 8346144: add ClearAllFramePops function to speedup debugger single stepping in some cases
Testing:
Progress
Warning
8346143: add ClearAllFramePops function to speedup debugger single stepping in some cases
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22744/head:pull/22744
$ git checkout pull/22744
Update a local copy of the PR:
$ git checkout pull/22744
$ git pull https://git.openjdk.org/jdk.git pull/22744/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22744
View PR using the GUI difftool:
$ git pr show -t 22744
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22744.diff
Using Webrev
Link to Webrev Comment