8346048: test/lib/containers/docker/DockerRunOptions.java uses addJavaOpts() from ctor

[lmesnik]

Trivial fix to avoid using methods from DockerRunOptions().

Don't methods final, just for using them in ctor.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8346048: test/lib/containers/docker/DockerRunOptions.java uses addJavaOpts() from ctor (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22748/head:pull/22748
$ git checkout pull/22748

Update a local copy of the PR:
$ git checkout pull/22748
$ git pull https://git.openjdk.org/jdk.git pull/22748/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22748

View PR using the GUI difftool:
$ git pr show -t 22748

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22748.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346048: test/lib/containers/docker/DockerRunOptions.java uses addJavaOpts() from ctor

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• ab1dbd4: 8346202: Correct typo in SQLPermission
• 6b022bb: 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out
• 3b9de11: 8319875: Add macOS implementation for jcmd System.map
• ebb27c2: 8346139: test_memset_with_concurrent_readers.cpp should not use
• c2f0ef5: 8346159: Disable CDS AOTClassLinking tests for JVMCI due to JDK-8345635
• 4b21fb9: 8343467: Remove unnecessary @SuppressWarnings annotations (security)
• e7fc0eb: 8345987: java.management has two Util.newObjectName methods (remove one)
• f647d4d: 8345936: Call ClassLoader.getResourceAsByteArray only for multi-release jar

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lmesnik The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (adebf259)
• 00: Full (966824ce)

[dholmes-ora]

Don't methods final, just for using them in ctor.

I would be more inclined to make them final because there is no reason for them to be overridden. Took me a while to realize what was being complained about here: potential invocation of a subclass implementation of the method before the instance is fully initialized.

[lmesnik]

Yes, should be mentioned that it is just to fix javac warning. I am not sure if anyone going extend this class, so let make the methods final. If anyone wants to override them they should deal with javac warnings/errors/

[dholmes-ora]

Seems fine to me. Thanks