8346231: RISC-V: Fix incorrect assertion in SharedRuntime::generate_handler_blob

[RealFYang]

Hi, please review this small change fixing several typos in assertion code.

I find that the verification of encoding of the poll instruction in this blob is not correct.
The code loads the instruction and checks for three bit fields, but it uses wrong masks. This
won't trigger an assertion failure as the masks used are the same as the expected values.

Testing on linux-riscv64 platform:

• hotspot:tier1 (fastdebug)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8346231: RISC-V: Fix incorrect assertion in SharedRuntime::generate_handler_blob (Bug - P4)

Reviewers

• Feilong Jiang (@feilongjiang - Committer)
• Robbin Ehn (@robehn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22750/head:pull/22750
$ git checkout pull/22750

Update a local copy of the PR:
$ git checkout pull/22750
$ git pull https://git.openjdk.org/jdk.git pull/22750/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22750

View PR using the GUI difftool:
$ git pr show -t 22750

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22750.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346231: RISC-V: Fix incorrect assertion in SharedRuntime::generate_handler_blob

Reviewed-by: fjiang, rehn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 31c3b19: 8346174: UMAX/UMIN are missing from XXXVector::reductionOperations
• c75b1d4: 8346082: Output JVMTI agent information in hserr files
• 51662c2: 8346232: Remove leftovers of the jar --normalize feature
• d335941: 8345678: compute_modifiers should not be in create_mirror
• 57adf64: 8346261: Cleanup in JDP tests
• 23708d0: 8346257: Problemlist jdp tests for macosx-aarch64
• f8974ba: 8345838: Remove the appcds/javaldr/AnonVmClassesDuringDump.java test
• e7d21fc: 8346285: Update jarsigner compatibility test for change in default digest algorithm
• cb92595: 8336356: [s390x] preserve Vector Register before using for string compress / expand
• d737978: 8343477: Remove unnecessary @SuppressWarnings annotations (compiler)
• ... and 11 more: https://git.openjdk.org/jdk/compare/3b9de117e83a7875df7fd2ddcc9d896f027e2c92...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@RealFYang The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[RealFYang]

/label remove hotspot-compiler

[openjdk]

@RealFYang
The hotspot-compiler label was successfully removed.

[openjdk]

@RealFYang The hotspot-runtime label was not set.

[RealFYang]

/label add hotspot-runtime

[openjdk]

@RealFYang
The hotspot-runtime label was successfully added.

[feilongjiang]

Nice catch!

[mlbridge]

Webrevs

• 00: Full (b8c8910b)

[robehn]

Thanks!