Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321818: vmTestbase/nsk/stress/strace/strace015.java failed with 'Cannot read the array length because "<local4>" is null' #22756

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Dec 16, 2024

Please review this simple update to the strace tests that adds a check for a null entry.

Testing:

  • self
  • tiers 1-3 (sanity)

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321818: vmTestbase/nsk/stress/strace/strace015.java failed with 'Cannot read the array length because "<local4>" is null' (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22756/head:pull/22756
$ git checkout pull/22756

Update a local copy of the PR:
$ git checkout pull/22756
$ git pull https://git.openjdk.org/jdk.git pull/22756/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22756

View PR using the GUI difftool:
$ git pr show -t 22756

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22756.diff

Using Webrev

Link to Webrev Comment

…not read the array length because "<local4>" is null'
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2024

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2024
@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@dholmes-ora To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@dholmes-ora
Copy link
Member Author

/label add hotspot-runtime
/label add hotspot

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 16, 2024
@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@dholmes-ora
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 16, 2024
@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@dholmes-ora
The hotspot label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 16, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant