-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8346278: Clean up some flag handing in flags-cflags.m4 #22762
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Verified that this builds properly on GHA and the Oracle CI system. |
/integrate |
Going to push as commit 3030230.
Your commit was automatically rebased without conflicts. |
WARNING_CFLAGS_JVM should not be used to set arbitrary warning flags for Hotspot.
We do not need to check for gcc 6+ anymore.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22762/head:pull/22762
$ git checkout pull/22762
Update a local copy of the PR:
$ git checkout pull/22762
$ git pull https://git.openjdk.org/jdk.git pull/22762/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22762
View PR using the GUI difftool:
$ git pr show -t 22762
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22762.diff
Using Webrev
Link to Webrev Comment