Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346278: Clean up some flag handing in flags-cflags.m4 #22762

Closed
wants to merge 1 commit into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Dec 16, 2024

WARNING_CFLAGS_JVM should not be used to set arbitrary warning flags for Hotspot.

We do not need to check for gcc 6+ anymore.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346278: Clean up some flag handing in flags-cflags.m4 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22762/head:pull/22762
$ git checkout pull/22762

Update a local copy of the PR:
$ git checkout pull/22762
$ git pull https://git.openjdk.org/jdk.git pull/22762/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22762

View PR using the GUI difftool:
$ git pr show -t 22762

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22762.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2024

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346278: Clean up some flag handing in flags-cflags.m4

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • d737978: 8343477: Remove unnecessary @SuppressWarnings annotations (compiler)
  • 8133eb2: 8346150: Jib dependency on autoconf missing for 'docs' profile
  • 45a3297: 8346248: serviceability/dcmd/vm/{SystemMapTest.java,SystemMapTest.java} failing on macos-aarch64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Dec 16, 2024
@magicus magicus marked this pull request as ready for review December 16, 2024 15:08
@magicus
Copy link
Member Author

magicus commented Dec 16, 2024

Verified that this builds properly on GHA and the Oracle CI system.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 16, 2024
@magicus
Copy link
Member Author

magicus commented Dec 16, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

Going to push as commit 3030230.
Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 16, 2024
@openjdk openjdk bot closed this Dec 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 16, 2024
@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@magicus Pushed as commit 3030230.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the clean-up-jvm-cflags branch December 17, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants