-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8346234: javax/swing/text/DefaultEditorKit/4278839/bug4278839.java still fails in CI #22768
Conversation
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 87 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
|
||
passed &= moveCaret(true) == 1; | ||
System.out.println("passed1 moveCaret1 " + passed); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are trying to get more information here why not logging the actual position of the caret after the move? Either inside the moveCaret() method or just add a new variable like
int caret;
And then every time you do the test you assign it.
passed &= (caret = moveCaret(true)) == 1;
and then you can just output the new caret position after each iteration like "Expected position 1 actual position " + caret.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point..logged..
/integrate |
Going to push as commit 466c00a.
Your commit was automatically rebased without conflicts. |
Test seem to fail in CI due to caret position not in expected position after pressing VK_RIGHT/VK_LEFT.
Added some log which shows the same
Added some delay for this slow system..Tested to pass in several systems..link in JBS
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22768/head:pull/22768
$ git checkout pull/22768
Update a local copy of the PR:
$ git checkout pull/22768
$ git pull https://git.openjdk.org/jdk.git pull/22768/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22768
View PR using the GUI difftool:
$ git pr show -t 22768
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22768.diff
Using Webrev
Link to Webrev Comment