Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346234: javax/swing/text/DefaultEditorKit/4278839/bug4278839.java still fails in CI #22768

Closed
wants to merge 2 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Dec 16, 2024

Test seem to fail in CI due to caret position not in expected position after pressing VK_RIGHT/VK_LEFT.
Added some log which shows the same


passed1 moveCaret1 true
passed2 moveCaret5 true
passed3 moveCaret8 true
passed4 moveCaret9 false
passed5 moveCaret13 false
passed6 moveCaret16 false
passed7 moveCaret17 false

Added some delay for this slow system..Tested to pass in several systems..link in JBS


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346234: javax/swing/text/DefaultEditorKit/4278839/bug4278839.java still fails in CI (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22768/head:pull/22768
$ git checkout pull/22768

Update a local copy of the PR:
$ git checkout pull/22768
$ git pull https://git.openjdk.org/jdk.git pull/22768/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22768

View PR using the GUI difftool:
$ git pr show -t 22768

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22768.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2024

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346234: javax/swing/text/DefaultEditorKit/4278839/bug4278839.java still fails in CI

Reviewed-by: kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

  • 87804f2: 8346294: Invalid lint category specified in compiler.properties
  • 18d1d61: 8346046: Enable copyright header format check
  • a7631cc: 8346235: RISC-V: Optimize bitwise AND with mask values
  • 929d4a5: 8346231: RISC-V: Fix incorrect assertion in SharedRuntime::generate_handler_blob
  • 3030230: 8346278: Clean up some flag handing in flags-cflags.m4
  • fd0207d: 8345327: JDK 24 RDP1 L10n resource files update
  • 31c3b19: 8346174: UMAX/UMIN are missing from XXXVector::reductionOperations
  • c75b1d4: 8346082: Output JVMTI agent information in hserr files
  • 51662c2: 8346232: Remove leftovers of the jar --normalize feature
  • d335941: 8345678: compute_modifiers should not be in create_mirror
  • ... and 77 more: https://git.openjdk.org/jdk/compare/8de0622c3a5c9e01e79659ef0b43b1b01dfa5cf6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2024
@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 16, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2024

Webrevs


passed &= moveCaret(true) == 1;
System.out.println("passed1 moveCaret1 " + passed);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are trying to get more information here why not logging the actual position of the caret after the move? Either inside the moveCaret() method or just add a new variable like
int caret;
And then every time you do the test you assign it.
passed &= (caret = moveCaret(true)) == 1;
and then you can just output the new caret position after each iteration like "Expected position 1 actual position " + caret.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point..logged..

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 17, 2024
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 17, 2024

Going to push as commit 466c00a.
Since your change was applied there have been 88 commits pushed to the master branch:

  • bd3c0be: 8268611: jar --validate should check targeted classes in MR-JAR files
  • 87804f2: 8346294: Invalid lint category specified in compiler.properties
  • 18d1d61: 8346046: Enable copyright header format check
  • a7631cc: 8346235: RISC-V: Optimize bitwise AND with mask values
  • 929d4a5: 8346231: RISC-V: Fix incorrect assertion in SharedRuntime::generate_handler_blob
  • 3030230: 8346278: Clean up some flag handing in flags-cflags.m4
  • fd0207d: 8345327: JDK 24 RDP1 L10n resource files update
  • 31c3b19: 8346174: UMAX/UMIN are missing from XXXVector::reductionOperations
  • c75b1d4: 8346082: Output JVMTI agent information in hserr files
  • 51662c2: 8346232: Remove leftovers of the jar --normalize feature
  • ... and 78 more: https://git.openjdk.org/jdk/compare/8de0622c3a5c9e01e79659ef0b43b1b01dfa5cf6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 17, 2024
@openjdk openjdk bot closed this Dec 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 17, 2024
@openjdk
Copy link

openjdk bot commented Dec 17, 2024

@prsadhuk Pushed as commit 466c00a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8346234 branch December 17, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants