Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346438: [JVMCI] Speculation encoding improvements #22771

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tkrodriguez
Copy link
Contributor

@tkrodriguez tkrodriguez commented Dec 16, 2024

This is a draft of some basic improvements to speculation encoding and sanity checking


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346438: [JVMCI] Speculation encoding improvements (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22771/head:pull/22771
$ git checkout pull/22771

Update a local copy of the PR:
$ git checkout pull/22771
$ git pull https://git.openjdk.org/jdk.git pull/22771/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22771

View PR using the GUI difftool:
$ git pr show -t 22771

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22771.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2024

👋 Welcome back never! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@tkrodriguez The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Dec 16, 2024
@tkrodriguez tkrodriguez force-pushed the tkr-speculation-improvements branch from 653f72a to 8eb2c0c Compare December 17, 2024 16:19
@tkrodriguez tkrodriguez changed the title Improve encoding and sanity checking of speculations 8346438: [JVMCI] Speculation encoding improvements Dec 17, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 10, 2025

@tkrodriguez This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

1 participant