Draft: 8331717: C2: Crash with SIGFPE Because Loop Predication Wrongly Hoists Division Requiring Zero Check

[merykitty]

WIP

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22855/head:pull/22855
$ git checkout pull/22855

Update a local copy of the PR:
$ git checkout pull/22855
$ git pull https://git.openjdk.org/jdk.git pull/22855/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22855

View PR using the GUI difftool:
$ git pr show -t 22855

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22855.diff

[bridgekeeper]

👋 Welcome back qamai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@merykitty The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[merykitty]

@chhagedorn I try a different approach that dynamically checks if the division is really depends_only_on_test. I think this is a more suitable solution as it fixes the semantics of depends_only_on_test for division. I believe it also removes the need for PhaseIterGVN::no_dependent_zero_check, too. What do you think?