8342393: Promote commutative vector IR node sharing

[jatin-bhateja]

Patch promotes the sharing of commutative vector IR with the same inputs but different input ordering.
Unlike scalar IR where we perform edge swapping by sorting inputs based on node indices during IR idealization, for vector IR we chose a simpler approach to decorate commutative operations with a special node-level flag during IR construction thus
obviating any dependency on explicit idealization routines. This flag is later used during GVN hashing to enable node sharing.

Following are the performance stats for JMH micro included with the patch.

Granite Rapids (P-core Xeon Server)
Baseline : 
Benchmark                                                                (size)   Mode  Cnt      Score   Error   Units
VectorCommutativeOperSharingBenchmark.commutativeByteOperationShairing     1024  thrpt    2   8982.549          ops/ms
VectorCommutativeOperSharingBenchmark.commutativeIntOperationShairing      1024  thrpt    2   6072.773          ops/ms
VectorCommutativeOperSharingBenchmark.commutativeLongOperationShairing     1024  thrpt    2   2368.856          ops/ms
VectorCommutativeOperSharingBenchmark.commutativeShortOperationShairing    1024  thrpt    2  15215.087          ops/ms

Withopt:
Benchmark                                                                (size)   Mode  Cnt      Score   Error   Units
VectorCommutativeOperSharingBenchmark.commutativeByteOperationShairing     1024  thrpt    2  11963.554          ops/ms
VectorCommutativeOperSharingBenchmark.commutativeIntOperationShairing      1024  thrpt    2   7036.088          ops/ms
VectorCommutativeOperSharingBenchmark.commutativeLongOperationShairing     1024  thrpt    2   2906.731          ops/ms
VectorCommutativeOperSharingBenchmark.commutativeShortOperationShairing    1024  thrpt    2  17148.131          ops/ms

Sierra Forest (E-core Xeon Server)
Baseline:
Benchmark                                                                (size)   Mode  Cnt     Score   Error   Units
VectorCommutativeOperSharingBenchmark.commutativeByteOperationShairing     1024  thrpt    2  2444.359          ops/ms
VectorCommutativeOperSharingBenchmark.commutativeIntOperationShairing      1024  thrpt    2  1710.256          ops/ms
VectorCommutativeOperSharingBenchmark.commutativeLongOperationShairing     1024  thrpt    2   308.766          ops/ms
VectorCommutativeOperSharingBenchmark.commutativeShortOperationShairing    1024  thrpt    2  3902.179          ops/ms

Withopt:
Benchmark                                                                (size)   Mode  Cnt     Score   Error   Units
VectorCommutativeOperSharingBenchmark.commutativeByteOperationShairing     1024  thrpt    2  3352.839          ops/ms
VectorCommutativeOperSharingBenchmark.commutativeIntOperationShairing      1024  thrpt    2  2918.805          ops/ms
VectorCommutativeOperSharingBenchmark.commutativeLongOperationShairing     1024  thrpt    2   409.482          ops/ms
VectorCommutativeOperSharingBenchmark.commutativeShortOperationShairing    1024  thrpt    2  6955.057          ops/ms

Please review and share your comments.

Best Regards,
Jatin

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8342393: Promote commutative vector IR node sharing (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22863/head:pull/22863
$ git checkout pull/22863

Update a local copy of the PR:
$ git checkout pull/22863
$ git pull https://git.openjdk.org/jdk.git pull/22863/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22863

View PR using the GUI difftool:
$ git pr show -t 22863

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22863.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@jatin-bhateja The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full - Incremental (86d0145c)
• 05: Full - Incremental (32919318)
• 04: Full - Incremental (e9be0de1)
• 03: Full - Incremental (39184960)
• 02: Full - Incremental (a4c52ecc)
• 01: Full - Incremental (f42645a1)
• 00: Full (21b2ffd8)

[iwanowww]

Nice improvement, Jatin.

[eme64]

Looks promising, thanks for the work!

[openjdk]

@jatin-bhateja Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.