Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346717: serviceability/dcmd/vm/SystemDumpMapTest.java failing on Windows with "Stack base not yet set for thread id" #22870

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

stooke
Copy link
Contributor

@stooke stooke commented Dec 23, 2024

This test fixes an issue with incomplete Windows threads not yet having a stack. A test for a null stack_base is added to guard against the potential null dereference. An additional test using ZGC is added to the jtreg SystemMapTest.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346717: serviceability/dcmd/vm/SystemDumpMapTest.java failing on Windows with "Stack base not yet set for thread id" (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22870/head:pull/22870
$ git checkout pull/22870

Update a local copy of the PR:
$ git checkout pull/22870
$ git pull https://git.openjdk.org/jdk.git pull/22870/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22870

View PR using the GUI difftool:
$ git pr show -t 22870

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22870.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2024

👋 Welcome back stooke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8346717: serviceability/dcmd/vm/SystemDumpMapTest.java failing on Windows with "Stack base not yet set for thread id" 8346717: serviceability/dcmd/vm/SystemDumpMapTest.java failing on Windows with "Stack base not yet set for thread id" Dec 23, 2024
@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@stooke To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@stooke
Copy link
Contributor Author

stooke commented Dec 23, 2024

/label jcmd

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@stooke
The label jcmd is not a valid label.
These labels are valid:

  • graal
  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@stooke
Copy link
Contributor Author

stooke commented Dec 23, 2024

/label hotspot serviceability

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org serviceability serviceability-dev@openjdk.org labels Dec 23, 2024
@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@stooke
The hotspot label was successfully added.

The serviceability label was successfully added.

@openjdk
Copy link

openjdk bot commented Dec 24, 2024

⚠️ @stooke This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@stooke stooke marked this pull request as ready for review December 24, 2024 16:16
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 24, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 24, 2024

Webrevs

* java.compiler
* java.management
* jdk.internal.jvmstat/sun.jvmstat.monitor
* @run testng/othervm -XX:+UsePerfData -XX:+UseZGC SystemMapTest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add separate testcase for ZGC. It is expected that hotspot tests are usually executed to ensure that all functionality works with any GC.
If you want to add it to ensure that regression testcase is always executed even no ZGC is set then please

  1. add
    * @requires vm.gc.Z
    So testcase is not executed if non-ZGC GC (Parallel/Serial etc) is set explicitly.
  2. Add
    * @bug 8346717
  3. Add id like
    * @test id=zgc
    to make testcase name clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants