8329951: var emits deprecation warnings that do not point to the file or position

[archiecobbs]

This PR fixes a bug that causes certain warnings to be emitted without source file location information.

Consider this example:

import java.util.*;
import java.util.function.*;
public class Example {

    @SuppressWarnings("deprecation")
    List<Observable> m1() { return null; }

    void m2() {
        for (var o : m1()) { }
    }
}

the compiler outputs this:

$ javac -Xlint:deprecation Example.java 
warning: [deprecation] Observable in java.util has been deprecated
1 warning

but it should instead output this:

Example.java:9: warning: [deprecation] Observable in java.util has been deprecated
        for (var o : m1()) { }
             ^
1 warning

The bug happens because the "synthetic" type that is installed dynamically for implicitly typed variables is not given a source code position. This makes some sense (?) because that type doesn't literally appear in the variable declaration; however, certain error messages expect to be able to point to the type portion of a variable declaration, so it also causes this bug (and presumably similar variants). To fix this, we just copy the position of the variable declaration itself to the synthetic type.

However, this change necessitated another change: The fix for JDK-8200199 added back in 2018 relies on the fact that the position of an implicitly typed variable is always null, so this change breaks that fix. But since then, a new method JCVariableDecl.declaredUsingVar() was added, so we can just use that test instead. This also makes the code a little clearer.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329951: var emits deprecation warnings that do not point to the file or position (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23683/head:pull/23683
$ git checkout pull/23683

Update a local copy of the PR:
$ git checkout pull/23683
$ git pull https://git.openjdk.org/jdk.git pull/23683/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23683

View PR using the GUI difftool:
$ git pr show -t 23683

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23683.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@archiecobbs The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (daacc44c)