-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8351927: Change VirtualThread implementation to use use FJP delayed task handling #24030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve/adjust implementation assumptions in jtreg and tck tests
viktorklang-ora
approved these changes
Apr 9, 2025
|
/integrate |
|
Going to push as commit 6c93ad4.
Your commit was automatically rebased without conflicts. |
|
@AlanBateman Pushed as commit 6c93ad4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This was referenced Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
core-libs
core-libs-dev@openjdk.org
integrated
Pull request has been integrated
serviceability
serviceability-dev@openjdk.org
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to JDK-8319447 to change the VirtualThread implementation to use FJP's delayed task handling.
The SPTE based implementation is not removed. It will continue to be used by tests. If custom schedulers are exposed in the future then they will use this implementation.
For timed-Object.wait, waitTimeoutExpired is changed to use lazySubmit to avoid signalling and increase the chance that the unparked virtual thread will continue on the current carrier. For timed-park, the timeout task is changed to reduced form of unpark that also uses lazySubmit, for the same reason.
jcmd Thread.vthread_scheduleris changed to no longer print the delay schedulers. Instead, the delayed task count will appear in the default scheduler output.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24030/head:pull/24030$ git checkout pull/24030Update a local copy of the PR:
$ git checkout pull/24030$ git pull https://git.openjdk.org/jdk.git pull/24030/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24030View PR using the GUI difftool:
$ git pr show -t 24030Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24030.diff
Using Webrev
Link to Webrev Comment