Skip to content

8354335: No longer deprecate wrapper class constructors for removal #24586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Apr 10, 2025

Remove forRemoval = true from @deprecated annotation of Boolean, Byte, Character, Double, Float, Integer, Long, Short.
And add SuppressWarnings("deprecation") where needed; and remove SuppressWarnings("removal")


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8354338 to be approved

Issues

  • JDK-8354335: No longer deprecate wrapper class constructors for removal (Enhancement - P4)
  • JDK-8354338: No longer deprecate wrapper class constructors for removal (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24586/head:pull/24586
$ git checkout pull/24586

Update a local copy of the PR:
$ git checkout pull/24586
$ git pull https://git.openjdk.org/jdk.git pull/24586/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24586

View PR using the GUI difftool:
$ git pr show -t 24586

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24586.diff

Using Webrev

Link to Webrev Comment

Remove forRemoval = true from Boolean, Byte, Character,
Double, Float, Integer, Long, Short.
And add SuppressWarnings where needed.
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 10, 2025

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Apr 10, 2025
@openjdk
Copy link

openjdk bot commented Apr 10, 2025

@RogerRiggs The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Apr 10, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 10, 2025

Webrevs

Copy link
Member

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wrapper classes and MemberName changes look good.

Copy link
Member

@bchristi-git bchristi-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org csr Pull request needs approved CSR before integration i18n i18n-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

4 participants