8367899: compiler/c2/gvn/TestBitCompressValueTransform.java intermittent timed out #27548

sendaoYan · 2025-09-29T13:52:59Z

Hi all,

After JDK-8260555 change the timeout factor from 4 to 1, make test compiler/c2/gvn/TestBitCompressValueTransform.java intermittent timed out.

There are 20 10k/20k loop count of loops in this test, this cause test need many CPU cycles to finish. If I reduce the loop count from 10k/20k to 100/200, the test failures descripted in JDK-8350896 also reproduced when the tested jdk is jdk25u. So it seems that there no need so many loop count for these tests.

Without the proposed change, the driver action finish about 65 sencods on linux-x64, with the proposed change the driver action finish about 1.5 seconds.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8367899: compiler/c2/gvn/TestBitCompressValueTransform.java intermittent timed out (Bug - P4)

Reviewers

Damon Fenacci (@dafedafe - Committer)
Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27548/head:pull/27548
$ git checkout pull/27548

Update a local copy of the PR:
$ git checkout pull/27548
$ git pull https://git.openjdk.org/jdk.git pull/27548/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27548

View PR using the GUI difftool:
$ git pr show -t 27548

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27548.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-09-29T13:55:14Z

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-09-29T13:55:30Z

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367899: compiler/c2/gvn/TestBitCompressValueTransform.java intermittent timed out

Reviewed-by: dfenacci, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 85 new commits pushed to the master branch:

069c569: 8368097: [asan] heap-buffer-overflow reported in ClassFileParser::skip_over_field_signature
85877e2: 8355354: C2 crashed: assert(_callee == nullptr || _callee == m) failed: repeated inline attempt with different callee
ba7bf43: 8365290: [perf] x86 ArrayFill intrinsic generates SPLIT_STORE for unaligned arrays
... and 82 more: https://git.openjdk.org/jdk/compare/75269fdb49aeb9d37acbbc1502c446a822fd30e3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-09-29T13:56:35Z

@sendaoYan The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-09-29T14:00:37Z

Webrevs

01: Full - Incremental (3fabfeca)
00: Full (a916d7d3)

dafedafe

Thanks @sendaoYan for fixing this. It looks ok to me but I'm just wondering: do we really need a loop for tests that don't use the counter? Shouldn't the IR framework already take care of warming up and compiling the methods?

jdk/test/hotspot/jtreg/compiler/lib/ir_framework/Run.java

Lines 42 to 49 in 9d9c0e0

    
            *     <li><p>The framework warms {@code r} up by invoking it for a predefined number of iterations (default: 2000) 
        
            *            or any number specified by an additional {@link Warmup} annotation at the run method {@code r} or by using 
        
            *            {@link TestFramework#setDefaultWarmup(int)} (could also be 0 which skips the warm-up completely which is 
        
            *            similar to simulating {@code -Xcomp}). More information about the warm-up in general can be found in 
        
            *            {@link Warmup @Warmup}.</li> 
        
            *     <li><p>After the warm-up, the framework compiles the test method {@code t} at the specified compilation level set by 
        
            *            {@link Test#compLevel()} (default {@link CompLevel#ANY} will pick the highest available level which is usually 
        
            *            {@link CompLevel#C2}).</li>

sendaoYan · 2025-09-29T14:47:29Z

I'm just wondering: do we really need a loop for tests that don't use the counter? Shouldn't the IR framework already take care of warming up and compiling the methods?

Maybe we can remove all the loop for this test in this PR?

…ent timed out

sendaoYan · 2025-09-30T06:29:54Z

I have remove the loops which do not use the loop counter variable or do not use the random number.

…ndom number

chhagedorn

Removing the loops looks good! As pointed out by @dafedafe, the IR framework will indeed take care of warming the tests up.

chhagedorn · 2025-10-06T07:13:18Z

test/hotspot/jtreg/compiler/c2/gvn/TestBitCompressValueTransform.java

    }

    @Run(test = "test1")
    public void run1(RunInfo info) {


While at it, you can also remove all the unused RunInfo parameters. But up to you if you want to squeeze that in here as well - it's only a clean-up that is not that important.

Sorry for missed this comment......

No worries!

dafedafe

Thanks for the cleanup @sendaoYan. LGTM

sendaoYan · 2025-10-06T09:25:23Z

Thanks for the reviews and suggestions@dafedafe @chhagedorn

/integrate

openjdk · 2025-10-06T09:26:56Z

Going to push as commit 2c114d6.
Since your change was applied there have been 88 commits pushed to the master branch:

baf8bc5: 8369038: Parallel: Use NMethodMarkingScope and ThreadsClaimTokenScope in psParallelCompact
59e8743: 8368753: IGV: improve CFG view of difference graphs
e6781fd: 8367601: Remove held_monitor_count
... and 85 more: https://git.openjdk.org/jdk/compare/75269fdb49aeb9d37acbbc1502c446a822fd30e3...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-10-06T09:27:06Z

@sendaoYan Pushed as commit 2c114d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 29, 2025

openjdk bot added the rfr Pull request is ready for review label Sep 29, 2025

dafedafe reviewed Sep 29, 2025

View reviewed changes

8367899: compiler/c2/gvn/TestBitCompressValueTransform.java intermitt…

a916d7d

…ent timed out

Remove the loop which do not use the loop variable i or do not use ra…

3fabfec

…ndom number

chhagedorn approved these changes Oct 6, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 6, 2025

dafedafe approved these changes Oct 6, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Oct 6, 2025

openjdk bot closed this Oct 6, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 6, 2025

sendaoYan deleted the jbs8367899 branch October 6, 2025 09:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8367899: compiler/c2/gvn/TestBitCompressValueTransform.java intermittent timed out #27548

8367899: compiler/c2/gvn/TestBitCompressValueTransform.java intermittent timed out #27548

Uh oh!

sendaoYan commented Sep 29, 2025 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Sep 29, 2025

Uh oh!

openjdk bot commented Sep 29, 2025 •

edited

Loading

Uh oh!

openjdk bot commented Sep 29, 2025 •

edited

Loading

Uh oh!

mlbridge bot commented Sep 29, 2025 •

edited

Loading

Uh oh!

dafedafe left a comment

Uh oh!

sendaoYan commented Sep 29, 2025

Uh oh!

sendaoYan commented Sep 30, 2025 •

edited

Loading

Uh oh!

chhagedorn left a comment

Uh oh!

chhagedorn Oct 6, 2025

Uh oh!

sendaoYan Oct 6, 2025

Uh oh!

chhagedorn Oct 6, 2025

Uh oh!

dafedafe left a comment

Uh oh!

sendaoYan commented Oct 6, 2025

Uh oh!

openjdk bot commented Oct 6, 2025

Uh oh!

openjdk bot commented Oct 6, 2025

Uh oh!

Uh oh!

	* <li><p>The framework warms {@code r} up by invoking it for a predefined number of iterations (default: 2000)
	* or any number specified by an additional {@link Warmup} annotation at the run method {@code r} or by using
	* {@link TestFramework#setDefaultWarmup(int)} (could also be 0 which skips the warm-up completely which is
	* similar to simulating {@code -Xcomp}). More information about the warm-up in general can be found in
	* {@link Warmup @Warmup}.</li>
	* <li><p>After the warm-up, the framework compiles the test method {@code t} at the specified compilation level set by
	* {@link Test#compLevel()} (default {@link CompLevel#ANY} will pick the highest available level which is usually
	* {@link CompLevel#C2}).</li>

8367899: compiler/c2/gvn/TestBitCompressValueTransform.java intermittent timed out #27548

8367899: compiler/c2/gvn/TestBitCompressValueTransform.java intermittent timed out #27548

Uh oh!

Conversation

sendaoYan commented Sep 29, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Sep 29, 2025

Uh oh!

openjdk bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

dafedafe left a comment

Choose a reason for hiding this comment

Uh oh!

sendaoYan commented Sep 29, 2025

Uh oh!

sendaoYan commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chhagedorn left a comment

Choose a reason for hiding this comment

Uh oh!

chhagedorn Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

sendaoYan Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

chhagedorn Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

dafedafe left a comment

Choose a reason for hiding this comment

Uh oh!

sendaoYan commented Oct 6, 2025

Uh oh!

openjdk bot commented Oct 6, 2025

Uh oh!

openjdk bot commented Oct 6, 2025

Uh oh!

Uh oh!

sendaoYan commented Sep 29, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Sep 29, 2025 •

edited

Loading

openjdk bot commented Sep 29, 2025 •

edited

Loading

mlbridge bot commented Sep 29, 2025 •

edited

Loading

sendaoYan commented Sep 30, 2025 •

edited

Loading