8320677: Printer tests use invalid '@run main/manual=yesno #27916

anass-baya · 2025-10-21T14:14:46Z

The tests :
test/jdk/java/awt/print/PrinterJob/PolylinePrintingTest.java
test/jdk/java/awt/print/PrinterJob/PageRanges.java

were failing because the Argument yesno to 'manual' option is invalid
the fix is as follow :

Removed yesno
Used PassFailJFrame manual test framework
add the missing keyboard 'test' to PolylinePrintingTest.java

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8320677: Printer tests use invalid '@run main/manual=yesno (Bug - P4)

Reviewers

Alexey Ivanov (@aivanov-jdk - Reviewer)
Damon Nguyen (@DamonGuy - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27916/head:pull/27916
$ git checkout pull/27916

Update a local copy of the PR:
$ git checkout pull/27916
$ git pull https://git.openjdk.org/jdk.git pull/27916/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27916

View PR using the GUI difftool:
$ git pr show -t 27916

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27916.diff

Using Webrev

Link to Webrev Comment

test/jdk/java/awt/print/PrinterJob/PageRanges.java test/jdk/java/awt/print/PrinterJob/PageRangesDlgTest.java To use PassFailJFrame

…to use PassFailJFrame

bridgekeeper · 2025-10-21T14:17:12Z

👋 Welcome back abaya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-10-21T14:18:45Z

@anass-baya This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320677: Printer tests use invalid '@run main/manual=yesno

Reviewed-by: aivanov, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 320 new commits pushed to the master branch:

be18e7e: 8064922: [macos] Test javax/swing/JTabbedPane/4624207/bug4624207.java fails
0744db8: 8367002: Missing compiled exception handler for "recursive" exception
2a8cbd9: 8359472: JVM crashes when attaching a dynamic agent before JVMTI_PHASE_LIVE
... and 317 more: https://git.openjdk.org/jdk/compare/c54dcefbfd2eb44a569767740dc053813c4f6fe1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @DamonGuy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2025-10-21T14:19:44Z

@anass-baya The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-10-21T15:30:33Z

Webrevs

test/jdk/java/awt/print/PrinterJob/PageRanges.java

aivanov-jdk · 2025-10-21T17:24:41Z

test/jdk/java/awt/print/PrinterJob/PageRanges.java

+        PassFailJFrame passFailJFrame = new PassFailJFrame(INSTRUCTIONS);
+        passFailJFrame.positionTestWindow(null, PassFailJFrame.Position.HORIZONTAL);


Use PassFailJFrame.builder() to configure and create an instance of PassFailJFrame.

Hello @aivanov-jdk,
Thank you for your review.
I used this approach to position the instruction window on the left side of the screen so that it won’t be hidden by the print dialog.
Is it possible to do something similar with the PassFailJFrame.builder()?

The builder supports all the features that you can get when using a PassFailJFrame constructor and more.

When you have no test UI, the instructions frame will stay at the centre of the screen when you use the builder. When you call PassFailJFrame.positionTestWindow(null, PassFailJFrame.Position.HORIZONTAL), the instructions frame is still moved to the left as if there's a test window.

test/jdk/java/awt/print/PrinterJob/PageRanges.java

test/jdk/java/awt/print/PrinterJob/PolylinePrintingTest.java

test/jdk/java/awt/print/PrinterJob/PageRanges.java

test/jdk/java/awt/print/PrinterJob/PolylinePrintingTest.java

aivanov-jdk · 2025-10-22T10:57:17Z

test/jdk/java/awt/print/PrinterJob/PolylinePrintingTest.java

+    public static void main(String[] args) throws Exception {
+        PassFailJFrame passFailJFrame = PassFailJFrame.builder()
+                .instructions(INSTRUCTIONS)
+                .rows((int) INSTRUCTIONS.lines().count() + 2)
+                .columns(45)
+                .build();
+
+        new PolylinePrintingTest();
+
+        passFailJFrame.awaitAndCheck();
+    }


This second test may also throw jtreg.SkippedException if the printer is not available. Then you can remove this statement from the instructions.

I would also place the test code inside the main method as it's done in the PageRanges.java test.

I also think setting the page format and paper isn't necessary to reproduce the original bug JDK-8041902, so this can be removed from the test, which will make the code small enough to inline into the main method.

Co-authored-by: Alexey Ivanov <alexey.ivanov@oracle.com>

…ot available - Enhancments

anass-baya · 2025-10-22T23:24:11Z

/integrate

openjdk · 2025-10-22T23:24:46Z

@anass-baya
Your change (at version 4803d8a) is now ready to be sponsored by a Committer.

sendaoYan · 2025-10-23T06:28:17Z

/sponsor

openjdk · 2025-10-23T06:28:54Z

Going to push as commit ffcb158.
Since your change was applied there have been 321 commits pushed to the master branch:

3e20a93: 8370156: Fix jpackage IconTest
be18e7e: 8064922: [macos] Test javax/swing/JTabbedPane/4624207/bug4624207.java fails
0744db8: 8367002: Missing compiled exception handler for "recursive" exception
... and 318 more: https://git.openjdk.org/jdk/compare/c54dcefbfd2eb44a569767740dc053813c4f6fe1...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-10-23T06:29:04Z

@sendaoYan @anass-baya Pushed as commit ffcb158.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

anass-baya added 2 commits October 21, 2025 15:08

Convert :

d61932b

test/jdk/java/awt/print/PrinterJob/PageRanges.java test/jdk/java/awt/print/PrinterJob/PageRangesDlgTest.java To use PassFailJFrame

Convert test/jdk/java/awt/print/PrinterJob/PolylinePrintingTest.java …

ad2b596

…to use PassFailJFrame

anass-baya marked this pull request as draft October 21, 2025 14:14

Remove extra line

cda4eb3

openjdk bot added the client client-libs-dev@openjdk.org label Oct 21, 2025

anass-baya added 4 commits October 21, 2025 15:30

add bug ID

eb25625

Add bug ID

7a558b7

Update copyright

bf13bf2

Update copyright

c247b77

anass-baya changed the title ~~8320677: Convert Printer tests to use PassFailJFrame~~ 8320677: Printer tests use invalid '@run main/manual=yesno Oct 21, 2025

anass-baya marked this pull request as ready for review October 21, 2025 15:25

openjdk bot added the rfr Pull request is ready for review label Oct 21, 2025

aivanov-jdk suggested changes Oct 21, 2025

View reviewed changes

Using the PolylinePrintingTest builder

b3ce6cf

anass-baya marked this pull request as draft October 21, 2025 22:27

openjdk bot removed the rfr Pull request is ready for review label Oct 21, 2025

Verify printer availability at the beginning of the test execution

1724e0a

anass-baya marked this pull request as ready for review October 22, 2025 10:31

anass-baya requested a review from aivanov-jdk October 22, 2025 10:31

openjdk bot added the rfr Pull request is ready for review label Oct 22, 2025

aivanov-jdk suggested changes Oct 22, 2025

View reviewed changes

anass-baya and others added 2 commits October 22, 2025 12:14

Apply suggestions from code review

58ca7af

Co-authored-by: Alexey Ivanov <alexey.ivanov@oracle.com>

Remove page format - throw jtreg.SkippedException if the printer is n…

4803d8a

…ot available - Enhancments

anass-baya requested a review from aivanov-jdk October 22, 2025 12:15

aivanov-jdk approved these changes Oct 22, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 22, 2025

DamonGuy approved these changes Oct 22, 2025

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 22, 2025

openjdk bot added the integrated Pull request has been integrated label Oct 23, 2025

openjdk bot closed this Oct 23, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 23, 2025

		PassFailJFrame passFailJFrame = new PassFailJFrame(INSTRUCTIONS);
		passFailJFrame.positionTestWindow(null, PassFailJFrame.Position.HORIZONTAL);

8320677: Printer tests use invalid '@run main/manual=yesno #27916

8320677: Printer tests use invalid '@run main/manual=yesno #27916

Uh oh!

Conversation

anass-baya commented Oct 21, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Oct 21, 2025

Uh oh!

openjdk bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Uh oh!

aivanov-jdk Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

anass-baya Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aivanov-jdk Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anass-baya commented Oct 22, 2025

Uh oh!

openjdk bot commented Oct 22, 2025

Uh oh!

sendaoYan commented Oct 23, 2025

Uh oh!

openjdk bot commented Oct 23, 2025

Uh oh!

openjdk bot commented Oct 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

anass-baya commented Oct 21, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Oct 21, 2025 •

edited

Loading

openjdk bot commented Oct 21, 2025 •

edited

Loading

mlbridge bot commented Oct 21, 2025 •

edited

Loading

aivanov-jdk Oct 22, 2025 •

edited

Loading