Skip to content

Conversation

@wangweij
Copy link
Contributor

@wangweij wangweij commented Oct 21, 2025

Clean up more intermediate objects created during these operations.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370082: Intermediate objects clean up in ECDH, EdDSA, XDH, DHKEM, and HKDF (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27921/head:pull/27921
$ git checkout pull/27921

Update a local copy of the PR:
$ git checkout pull/27921
$ git pull https://git.openjdk.org/jdk.git pull/27921/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27921

View PR using the GUI difftool:
$ git pr show -t 27921

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27921.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2025

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 21, 2025

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370082: Intermediate objects clean up in ECDH, EdDSA, XDH, DHKEM, and HKDF

Reviewed-by: ascarpino, abarashev, fandreuzzi

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 93 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the security security-dev@openjdk.org label Oct 21, 2025
@openjdk
Copy link

openjdk bot commented Oct 21, 2025

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 21, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 21, 2025

Webrevs

Copy link
Member

@artur-oracle artur-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ascarpino ascarpino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 22, 2025
@wangweij wangweij changed the title 8370082: Intermediate objects clean up in DHKEM and HKDF 8370082: Intermediate objects clean up in ECDH, XDH, DHKEM, and HKDF Oct 22, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 22, 2025
Copy link
Member

@artur-oracle artur-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangweij wangweij changed the title 8370082: Intermediate objects clean up in ECDH, XDH, DHKEM, and HKDF 8370082: Intermediate objects clean up in ECDH, EdDSA, XDH, DHKEM, and HKDF Oct 22, 2025
Copy link
Contributor

@ascarpino ascarpino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates look good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

4 participants