8370503: Use String.newStringWithLatin1Bytes to simplify Integer/Long toString method #27929

wenshao · 2025-10-22T06:28:34Z

With the introduction of String.newStringWithLatin1Bytes, we can use it to simplify the toString methods of Integer and Long. By replacing the implementation that supports COMPACT_STRING = false with newStringWithLatin1Bytes, we gain the following benefits:

Simplified implementation
Strings with codeSize < 35 in Integer.toString(int) and Long.toString(long) can be inlined in C1, improving performance in early calls.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8370503: Use String.newStringWithLatin1Bytes to simplify Integer/Long toString method (Enhancement - P4)

Reviewers

Raffaello Giulietti (@rgiulietti - Reviewer)
Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27929/head:pull/27929
$ git checkout pull/27929

Update a local copy of the PR:
$ git checkout pull/27929
$ git pull https://git.openjdk.org/jdk.git pull/27929/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27929

View PR using the GUI difftool:
$ git pr show -t 27929

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27929.diff

Using Webrev

Link to Webrev Comment

…place conditional COMPACT_STRINGS checks with direct calls to\nString.newStringWithLatin1Bytes() for better code clarity and\nmaintainability. This change affects:\n\n- Integer.toString(int)\n- Integer.toUnsignedString0(int, int)\n- Long.toString(long)\n- Long.toUnsignedString0(long, int)\n\nThe new approach leverages the existing String.newStringWithLatin1Bytes()\nmethod which already handles the COMPACT_STRINGS logic internally. Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

bridgekeeper · 2025-10-22T06:30:20Z

👋 Welcome back swen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-10-22T06:31:22Z

@wenshao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370503: Use String.newStringWithLatin1Bytes to simplify Integer/Long toString method

Reviewed-by: rgiulietti, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

869112e: 8026776: Broken API names in API doc
6e898e2: 8369944: Notification can be lost due to interrupt in Object.wait
aaa9fbf: 8368365: ASAN errors should produce hs-err files and core dumps
... and 30 more: https://git.openjdk.org/jdk/compare/ed153ee2c4614c814da92c23c4741eed68ce1a0c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-10-22T06:32:00Z

@wenshao The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

j3graham · 2025-10-22T17:55:16Z

src/java.base/share/classes/java/lang/Integer.java

-            formatUnsignedIntUTF16(val, shift, buf, chars);
-            return new String(buf, UTF16);
-        }
+        byte[] buf = new byte[chars];


Should the array size be chars*2 in when compact strings is not in use?

There is no need to handle the case where COMPACT_STRING false is used, as it is inflate in java.lang.String#newStringWithLatin1Bytes.

rgiulietti · 2025-10-23T14:21:21Z

Nice cleanup.

mlbridge · 2025-10-23T14:29:29Z

Webrevs

01: Full - Incremental (9818de0b)
00: Full (cf7b33a8)

rgiulietti · 2025-10-23T14:32:51Z

@wenshao Seems like Integer.formatUnsignedIntUTF16() is no longer needed.

rgiulietti · 2025-10-23T14:33:34Z

Same for Long.formatUnsignedLong0UTF16()

rgiulietti

@wenshao Thanks for the cleanup

RogerRiggs

This cleanup looks good.

wenshao · 2025-10-24T16:42:41Z

/integrate

openjdk · 2025-10-24T16:44:00Z

Going to push as commit fd23a61.
Since your change was applied there have been 46 commits pushed to the master branch:

cc9483b: 8366182: Some PKCS11Tests are being skipped when they shouldn't
470eedb: 8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys
f73e56e: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo
... and 43 more: https://git.openjdk.org/jdk/compare/ed153ee2c4614c814da92c23c4741eed68ce1a0c...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-10-24T16:44:09Z

@wenshao Pushed as commit fd23a61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 22, 2025

j3graham reviewed Oct 22, 2025

View reviewed changes

wenshao changed the title ~~Simplify toString() implementations in Integer and Long~~ Use String.newStringWithLatin1Bytes to simplify Integer/Long toString method Oct 23, 2025

wenshao changed the title ~~Use String.newStringWithLatin1Bytes to simplify Integer/Long toString method~~ 8370503: Use String.newStringWithLatin1Bytes to simplify Integer/Long toString method Oct 23, 2025

wenshao marked this pull request as ready for review October 23, 2025 14:22

openjdk bot added the rfr Pull request is ready for review label Oct 23, 2025

clean up, from @rgiulietti

9818de0

rgiulietti approved these changes Oct 23, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 23, 2025

RogerRiggs approved these changes Oct 23, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Oct 24, 2025

openjdk bot closed this Oct 24, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 24, 2025

8370503: Use String.newStringWithLatin1Bytes to simplify Integer/Long toString method #27929

8370503: Use String.newStringWithLatin1Bytes to simplify Integer/Long toString method #27929

Conversation

wenshao commented Oct 22, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Oct 22, 2025

Uh oh!

openjdk bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

j3graham Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

wenshao Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

rgiulietti commented Oct 23, 2025

Uh oh!

mlbridge bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

rgiulietti commented Oct 23, 2025

Uh oh!

rgiulietti commented Oct 23, 2025

Uh oh!

rgiulietti left a comment

Choose a reason for hiding this comment

Uh oh!

RogerRiggs left a comment

Choose a reason for hiding this comment

Uh oh!

wenshao commented Oct 24, 2025

Uh oh!

openjdk bot commented Oct 24, 2025

Uh oh!

openjdk bot commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

wenshao commented Oct 22, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Oct 22, 2025 •

edited

Loading

openjdk bot commented Oct 22, 2025 •

edited

Loading

mlbridge bot commented Oct 23, 2025 •

edited

Loading