Skip to content

Conversation

@koushikthirupattur
Copy link
Contributor

@koushikthirupattur koushikthirupattur commented Oct 24, 2025

The classes are all generated; the actual bug is on line 631 of make/jdk/src/classes/build/tools/intpoly/FieldGen.java.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368301: sun/security/util/math/intpoly compiler warnings (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27967/head:pull/27967
$ git checkout pull/27967

Update a local copy of the PR:
$ git checkout pull/27967
$ git pull https://git.openjdk.org/jdk.git pull/27967/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27967

View PR using the GUI difftool:
$ git pr show -t 27967

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27967.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2025

👋 Welcome back koushikthirupattur! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added security security-dev@openjdk.org build build-dev@openjdk.org labels Oct 24, 2025
@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@koushikthirupattur The following labels will be automatically applied to this pull request:

  • build
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@ferakocz
Copy link
Contributor

Looks good to me.

@koushikthirupattur koushikthirupattur marked this pull request as ready for review October 27, 2025 20:18
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 27, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org rfr Pull request is ready for review security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants