Skip to content

Conversation

@lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Oct 24, 2025

Modules.enter completes all root modules, but in case of additional modules being added to the module graph via Modules.addExtraAddModules (either from javadoc, or using the CompilationTask.addModules, these extra modules may not be completed at this time. Normally, they are completed eventually, but if their module-infos contain import module, an NPE will appear while checking the import, before the complete happens.

The proposal herein is to consistently complete all modules in the module graph when the module graphs is setup.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8370334: javadoc NPE with "import module" statement

Issue

  • JDK-8370334: javadoc NPE with "import module" statement (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27974/head:pull/27974
$ git checkout pull/27974

Update a local copy of the PR:
$ git checkout pull/27974
$ git pull https://git.openjdk.org/jdk.git pull/27974/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27974

View PR using the GUI difftool:
$ git pr show -t 27974

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27974.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2025

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org compiler compiler-dev@openjdk.org labels Oct 24, 2025
@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@lahodaj The following labels will be automatically applied to this pull request:

  • compiler
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 24, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2025

Webrevs

@lahodaj lahodaj marked this pull request as draft October 24, 2025 15:30
@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org javadoc javadoc-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant