8370334: javadoc NPE with "import module" statement #27974
                
     Draft
            
            
          
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Modules.entercompletes all root modules, but in case of additional modules being added to the module graph viaModules.addExtraAddModules(either from javadoc, or using theCompilationTask.addModules, these extra modules may not be completed at this time. Normally, they are completed eventually, but if theirmodule-infos containimport module, an NPE will appear while checking the import, before the complete happens.The proposal herein is to consistently complete all modules in the module graph when the module graphs is setup.
Progress
Warning
8370334: javadoc NPE with "import module" statementIssue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27974/head:pull/27974$ git checkout pull/27974Update a local copy of the PR:
$ git checkout pull/27974$ git pull https://git.openjdk.org/jdk.git pull/27974/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27974View PR using the GUI difftool:
$ git pr show -t 27974Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27974.diff
Using Webrev
Link to Webrev Comment