Skip to content

Conversation

@mhaessig
Copy link
Contributor

@mhaessig mhaessig commented Oct 24, 2025

This cleanup PR swaps and renames the immediate arguments of the two insrwi instruction macros in ppc.ad such that they correspond to the order and names in the manual. This involved swapping the arguments in all six usages. I hope this saves the next person trying to reason about this some confused hours.

Testing:

  • Github Actions
  • Running some relevant tests (compiler/c2/TestCharShortByteSwap.java, jdk/java/lang/Short/BitTwiddle.java, jdk/java/lang/Integer/BitTwiddle.java, compiler/codegen/Test6431242.java) in qemu

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370579: PPC: fix inswri immediate argument order (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27978/head:pull/27978
$ git checkout pull/27978

Update a local copy of the PR:
$ git checkout pull/27978
$ git pull https://git.openjdk.org/jdk.git pull/27978/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27978

View PR using the GUI difftool:
$ git pr show -t 27978

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27978.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2025

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 24, 2025
@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@mhaessig The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 24, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant