8370633: Remove dead code for Windows file path canonicalization functions

[bplb]

Remove the unused, vestigial functions wcanonicalizeWithPrefix and Java_java_io_WinNTFileSystem_canonicalizeWithPrefix0. With this change, the build in the CI succeeds on Windows.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8370633: Remove dead code for Windows file path canonicalization functions (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Iris Clark (@irisclark - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27981/head:pull/27981
$ git checkout pull/27981

Update a local copy of the PR:
$ git checkout pull/27981
$ git pull https://git.openjdk.org/jdk.git pull/27981/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27981

View PR using the GUI difftool:
$ git pr show -t 27981

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27981.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370633: Remove dead code for Windows file path canonicalization functions

Reviewed-by: alanb, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

• e7c7892: 8370197: Add missing @OverRide annotations in com.sun.beans package
• c3449de: 8360395: sun/security/tools/keytool/i18n.java user country is current user location instead of the language
• 32697bf: 8370501: vmTestbase/vm/gc/compact/Humongous_NonbranchyTree5M/TestDescription.java intermittent timed out
• ... and 38 more: https://git.openjdk.org/jdk/compare/afba636869bc297d0c9c29fbe7f2a1eb5929218b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4f85adcf)

[AlanBateman]

I think this dates from needing both a Win32FileSystem and WinNTFileSystem, so shouldn't be needed anymore. Can you make sure to do a test run with the changes? (a build test isn't enough).

[bplb]

/integrate

[openjdk]

Going to push as commit 4e8e55db602702715135d28a3a3b160e2101593b.
Since your change was applied there have been 56 commits pushed to the master branch:

• 70aa367: 8370520: GenShen: Track and report on promotion failures
• e4e457f: 8366871: (javac) legacy.properties seems to be an obsolete file
• 8151251: 8370370: Add still more cases to WorstCaseTests
• ... and 53 more: https://git.openjdk.org/jdk/compare/afba636869bc297d0c9c29fbe7f2a1eb5929218b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 4e8e55d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[bplb]

Can you make sure to do a test run with the changes? (a build test isn't enough).

Tier 1-3 tests passed. I also previously did a find+grep on the code base and didn't spot anything.