Skip to content

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Oct 24, 2025

Synchronize WPrinterJob calls which use the printDC to avoid crash in case of mis-use.
The printerDC is released when the job ends.
It is zero-ed out in the handle in which it is stored
The calls which expect it to be valid now all check for zero and return if it is zero.
The calls are made synchronized as is the call to endDoc which zeroes it, so that they cannot have it zeroed out whilst using it.

The tests are the same as in the fix for JDK-8370141 which is also under review.
Which ever is 2nd to be pushed will have to merge in the changes from the first


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370637: [Windows] Crash if use Graphics after PrintJob.end (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27984/head:pull/27984
$ git checkout pull/27984

Update a local copy of the PR:
$ git checkout pull/27984
$ git pull https://git.openjdk.org/jdk.git pull/27984/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27984

View PR using the GUI difftool:
$ git pr show -t 27984

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27984.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2025

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8370637 8370637: [Windows] Crash if use Graphics after PrintJob.end Oct 24, 2025
@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 24, 2025
@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 24, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant