8370637: [Windows] Crash if use Graphics after PrintJob.end #27984
+429
−72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronize WPrinterJob calls which use the printDC to avoid crash in case of mis-use.
The printerDC is released when the job ends.
It is zero-ed out in the handle in which it is stored
The calls which expect it to be valid now all check for zero and return if it is zero.
The calls are made synchronized as is the call to endDoc which zeroes it, so that they cannot have it zeroed out whilst using it.
The tests are the same as in the fix for JDK-8370141 which is also under review.
Which ever is 2nd to be pushed will have to merge in the changes from the first
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27984/head:pull/27984$ git checkout pull/27984Update a local copy of the PR:
$ git checkout pull/27984$ git pull https://git.openjdk.org/jdk.git pull/27984/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27984View PR using the GUI difftool:
$ git pr show -t 27984Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27984.diff
Using Webrev
Link to Webrev Comment