- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6.1k
8370649: Add intermittent tag for gc/shenandoah/generational/TestOldGrowthTriggers.java #27986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 👋 Welcome back syan! A progress list of the required criteria for merging this PR into  | 
| @sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the  
 As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the  | 
| @sendaoYan The following labels will be automatically applied to this pull request: 
 When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. | 
…rowthTriggers.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR. We will still investigate the test failure.
| Thanks for the reviews @earthling-amzn /integrate | 
| Going to push as commit b3e63ae. 
 Your commit was automatically rebased without conflicts. | 
| @sendaoYan Pushed as commit b3e63ae. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. | 
Hi all,
Test gc/shenandoah/generational/TestOldGrowthTriggers.java intermittent fails "'Trigger (Old): Old has overgrown' missing from stdout/stderr" with default JVM options by fastdebug build on linux-aarch64. The failure probability about 1/100.
Should we add '@key intermittent' tag for this test until the root cause has been fixed. The '@key intermittent' tag make some test infrasture disable or rerun this test automaticly when it's intermittent fails.
Test-fix only. no risk.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27986/head:pull/27986$ git checkout pull/27986Update a local copy of the PR:
$ git checkout pull/27986$ git pull https://git.openjdk.org/jdk.git pull/27986/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27986View PR using the GUI difftool:
$ git pr show -t 27986Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27986.diff
Using Webrev
Link to Webrev Comment