Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Oct 25, 2025

Hi all,

Test gc/shenandoah/generational/TestOldGrowthTriggers.java intermittent fails "'Trigger (Old): Old has overgrown' missing from stdout/stderr" with default JVM options by fastdebug build on linux-aarch64. The failure probability about 1/100.

Should we add '@key intermittent' tag for this test until the root cause has been fixed. The '@key intermittent' tag make some test infrasture disable or rerun this test automaticly when it's intermittent fails.

Test-fix only. no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370649: Add intermittent tag for gc/shenandoah/generational/TestOldGrowthTriggers.java (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27986/head:pull/27986
$ git checkout pull/27986

Update a local copy of the PR:
$ git checkout pull/27986
$ git pull https://git.openjdk.org/jdk.git pull/27986/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27986

View PR using the GUI difftool:
$ git pr show -t 27986

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27986.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 25, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370649: Add intermittent tag for gc/shenandoah/generational/TestOldGrowthTriggers.java

Reviewed-by: wkemper

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Oct 25, 2025
@openjdk
Copy link

openjdk bot commented Oct 25, 2025

@sendaoYan The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 25, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2025

Webrevs

Copy link
Contributor

@earthling-amzn earthling-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. We will still investigate the test failure.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 27, 2025
@sendaoYan
Copy link
Member Author

Thanks for the reviews @earthling-amzn

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

Going to push as commit b3e63ae.
Since your change was applied there have been 20 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 28, 2025
@openjdk openjdk bot closed this Oct 28, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@sendaoYan Pushed as commit b3e63ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8370649 branch October 28, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants