-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8373633: C2: Use interface receiver type to improve CHA decisions #28811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@iwanowww this pull request can not be integrated into git checkout cha.intf.recv
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
089b8f2 to
2551b03
Compare
| jvms, | ||
| allow_inline, | ||
| _prof_factor, | ||
| nullptr /*receiver_type*/, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no benefit to passing receiver_type here?
Strength-reducing an interface call to a virtual call for interfaces with
unique implementors can use receiver type information to narrow the context.
C2 tracks interface types and receiver type information can be used to reveal
an interface with a unique implementor which can't be derived from the call
site itself.
Since C2 effectively accumulates a union interface type from multiple subtype checks, iterating over individual components of a type may reveal a candidate for a strength-reduction. The only prerequisite is that a candidate has to be a subtype of the declared interface.
Testing: hs-tier1 - hs-tier5
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28811/head:pull/28811$ git checkout pull/28811Update a local copy of the PR:
$ git checkout pull/28811$ git pull https://git.openjdk.org/jdk.git pull/28811/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28811View PR using the GUI difftool:
$ git pr show -t 28811Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28811.diff
Using Webrev
Link to Webrev Comment