8343809: Add requires tag to mark tests that are incompatible with exploded image #28814
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into |
|
@lmesnik This change is no longer ready for integration - check the PR body for details. |
Webrevs
|
AlanBateman
reviewed
Dec 16, 2025
test/jtreg-ext/requires/VMProps.java
Outdated
| private String explodedImage() { | ||
| try { | ||
| Path jmodFile = Path.of(System.getProperty("java.home"), "jmods", "java.base.jmod"); | ||
| if (jmodFile.toFile().exists()) { |
Contributor
There was a problem hiding this comment.
In passing, the Path -> File conversion wouldn't be needed if you use Files.exists here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
jdk.explodedImage
might be used to filter tests incompatible with
make exploded-run-test TEST=...
The exploded-run-test mode is used only for quick manual testing and not in CI or ATR testing. However, it is make sense to reduce false positive failures so developers don't waste time during local testing.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28814/head:pull/28814$ git checkout pull/28814Update a local copy of the PR:
$ git checkout pull/28814$ git pull https://git.openjdk.org/jdk.git pull/28814/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28814View PR using the GUI difftool:
$ git pr show -t 28814Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28814.diff
Using Webrev
Link to Webrev Comment