Skip to content

Conversation

@smemery
Copy link
Contributor

@smemery smemery commented Dec 14, 2025

This change allows use of the AVX512_VBMI/VMBI2 instruction set to further optimize decompression/parsing of polynomial coefficients for ML-KEM. The speedup gained in the ML-KEM benchmarks for key generation is between 0.2 to 0.5%, encapsulation is 0.3 to 1.5%, and decapsulation is 0 to 0.9%.

Thank you to @sviswa7 and @ferakocz for their help in working through the early stages of this code with me.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8360934: Add AVX-512 intrinsics for ML-KEM - enhancement on AVX512_VBMI and AVX512_VBMI2 (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28815/head:pull/28815
$ git checkout pull/28815

Update a local copy of the PR:
$ git checkout pull/28815
$ git pull https://git.openjdk.org/jdk.git pull/28815/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28815

View PR using the GUI difftool:
$ git pr show -t 28815

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28815.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2025

👋 Welcome back smemery! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 14, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8360934: Add AVX-512 intrinsics for ML-KEM - enhancement on AVX512_VB… 8360934: Add AVX-512 intrinsics for ML-KEM - enhancement on AVX512_VBMI and AVX512_VBMI2 Dec 14, 2025
@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 14, 2025
@openjdk
Copy link

openjdk bot commented Dec 14, 2025

@smemery The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant