8372988: Test runtime/Nestmates/membership/TestNestHostErrorWithMultiThread.java failed: Unexpected interrupt

[dholmes-ora]

In the fix for JDK-8365526 we changed the set_nest_host_error code so that we would overwrite the message in the resolution error table, and free the previous copy of the message (the messages will always be the same). This was the wrong thing to do as the message could be in-use at the time it was freed, leading to either a missing message, or an assertion failure when we checked the messages for UTF8 validity.

The fix is to simply only ever set the message once (freeing it only when the entry is removed from the table).

Testing:

• TestNestHostErrorWithMultiThread.java with an augmented VM that inserts a delay that helped trigger the bug
• tiers 1-3 sanity

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372988: Test runtime/Nestmates/membership/TestNestHostErrorWithMultiThread.java failed: Unexpected interrupt (Bug - P3)

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)
• Ioi Lam (@iklam - Reviewer)
• Johan Sjölen (@jdksjolen - Reviewer) Review applies to 9332638b

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28817/head:pull/28817
$ git checkout pull/28817

Update a local copy of the PR:
$ git checkout pull/28817
$ git pull https://git.openjdk.org/jdk.git pull/28817/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28817

View PR using the GUI difftool:
$ git pr show -t 28817

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28817.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372988: Test runtime/Nestmates/membership/TestNestHostErrorWithMultiThread.java failed: Unexpected interrupt

Reviewed-by: coleenp, iklam, jsjolen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• 317788f: 8360160: ubuntu-22-04 machine is failing client tests
• 6aeabd4: 8370910: Cleanup terminology of UUID vs Global Identifiers in UUID
• f52d499: 8319589: Attach from root to a user java process not supported in Mac
• ... and 40 more: https://git.openjdk.org/jdk/compare/c46bed7292aad21b8cf9defcccac43c010a1f116...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (6bd0192e)
• 01: Full - Incremental (9332638b)
• 00: Full (e886320d)

[coleenp]

Now where do we free the duplicate nest host error?

[openjdk]

@dholmes-ora hotspot has been added to this pull request based on files touched in new commit(s).

[dholmes-ora]

/label remove hotspot

[openjdk]

@dholmes-ora
The hotspot label was successfully removed.

[coleenp]

Yes, this looks really good! Now the ResolutionErrorEntry "owns" the memory for the char* message and it's less confusing overall.

[dholmes-ora]

Thanks for the review @coleenp !

[iklam]

Looks good. Two minor nits.

[dholmes-ora]

Thanks for the reviews @iklam and @jdksjolen !

[dholmes-ora]

Re-testing completed. Thanks again for reviews.

/integrate

[openjdk]

Going to push as commit 1748737.
Since your change was applied there have been 43 commits pushed to the master branch:

• 317788f: 8360160: ubuntu-22-04 machine is failing client tests
• 6aeabd4: 8370910: Cleanup terminology of UUID vs Global Identifiers in UUID
• f52d499: 8319589: Attach from root to a user java process not supported in Mac
• ... and 40 more: https://git.openjdk.org/jdk/compare/c46bed7292aad21b8cf9defcccac43c010a1f116...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit 1748737.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.