8373429: gc/g1/TestCodeCacheUnloadDuringConcCycle fails on various platforms

[tschatzl]

Hi all,

this is hopefully the last fix attempt for the gc/g1/TestCodeCacheUnloadDuringConcCycle.java test that proves to be fairly unstable across some platforms.

The change adds more classes/code to be compiled during the test to fill the code cache faster, and more consistently exercise the code cachec loading.

I also opted to revert the change from https://bugs.openjdk.org/browse/JDK-8372860 because it (unsuccessfully) tried the same method. There is no need to prolong the test any more.

Testing: gha

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373429: gc/g1/TestCodeCacheUnloadDuringConcCycle fails on various platforms (Bug - P4)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28822/head:pull/28822
$ git checkout pull/28822

Update a local copy of the PR:
$ git checkout pull/28822
$ git pull https://git.openjdk.org/jdk.git pull/28822/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28822

View PR using the GUI difftool:
$ git pr show -t 28822

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28822.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373429: gc/g1/TestCodeCacheUnloadDuringConcCycle fails on various platforms

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

• 8402891: 8373355: C2: CompileCommand PrintIdealPhase should also print nodes that are not "reachable from below"
• 78c2d57: 8373668: Add override keyword to *Klass classes
• b1e8c4e: 8372543: Shenandoah: undercalculated the available size when soft max takes effect
• ... and 43 more: https://git.openjdk.org/jdk/compare/650de99fc662a3e8473391627df9e523b6b80727...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[snazarkin]

Test is passed on ARM32

[TheRealMDoerr]

This looks good. I just verified that this fixes the failures on AIX.

[MBaesken]

The ppc64 errors are gone also in our central CI tests.
Maybe the PR subject should be changed to aarch64 and ppc64 ? Or just say 'various platforms' ?

[mlbridge]

Webrevs

• 00: Full (114d08c4)