Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 15, 2025

Hi all,

This pull request contains a backport of commit 34f24131 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 15 Dec 2025 and was reviewed by Leonid Mesnik and David Holmes.

This clean backport PR will make all the docker tests receive -Djdk.test.docker.retain.image property correctly.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28826/head:pull/28826
$ git checkout pull/28826

Update a local copy of the PR:
$ git checkout pull/28826
$ git pull https://git.openjdk.org/jdk.git pull/28826/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28826

View PR using the GUI difftool:
$ git pr show -t 28826

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28826.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into jdk26 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 15, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 34f241317ecd7473cfb6dcc2e6e5cf3a40299e2c 8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests Dec 15, 2025
@openjdk
Copy link

openjdk bot commented Dec 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required serviceability serviceability-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Dec 15, 2025
@openjdk
Copy link

openjdk bot commented Dec 15, 2025

@sendaoYan The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 15, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 15, 2025

Webrevs

Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>
@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Dec 17, 2025
@sendaoYan
Copy link
Member Author

Change has been verified locally on linux-x64. This clean backport PR will make all the docker tests receive -Djdk.test.docker.retain.image property correctly.

Verify command:

j -Djdk.test.docker.image.name=jdk-build -Djdk.test.docker.image.version=11 -conc:20 $(git status -s | awk '{print $NF}' | sed "/ockerTestUtils.java/d" | xargs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants