8373677: Clear text HttpServer connection could fail fast if receiving SSL ClientHello

[dfuch]

The first byte of a SSL ClientHello handshake record is 0x16 (22).
If the first byte received on a HTTP/1.1 clear connection is 0x16, the HTTP server could fail fast, return 400 bad request and immediately close the connection.

This changeset extends the fail fast behaviour for other ineligible bytes, such as any byte corresponding to ASCII characters <= 31.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373677: Clear text HttpServer connection could fail fast if receiving SSL ClientHello (Enhancement - P4)

Reviewers

• Daniel Jeliński (@djelinski - Reviewer) Review applies to d7c25539
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28827/head:pull/28827
$ git checkout pull/28827

Update a local copy of the PR:
$ git checkout pull/28827
$ git pull https://git.openjdk.org/jdk.git pull/28827/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28827

View PR using the GUI difftool:
$ git pr show -t 28827

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28827.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373677: Clear text HttpServer connection could fail fast if receiving SSL ClientHello

Reviewed-by: jpai, djelinski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• e4636d6: 8373420: C2: Add true/false_proj*() methods for IfNode as a replacement for proj_out*(true/false)
• 9a23f8a: 8373552: ExactConversionsSupport: bad JLS links in javadoc

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dfuch The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (2fe11cf3)
• 02: Full - Incremental (05704ead)
• 01: Full - Incremental (d7c25539)
• 00: Full (d6d11c8c)

[dfuch]

/integrate

[openjdk]

Going to push as commit 5e7ae28.
Since your change was applied there have been 2 commits pushed to the master branch:

• e4636d6: 8373420: C2: Add true/false_proj*() methods for IfNode as a replacement for proj_out*(true/false)
• 9a23f8a: 8373552: ExactConversionsSupport: bad JLS links in javadoc

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch Pushed as commit 5e7ae28.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.