Skip to content

Conversation

@vy
Copy link
Contributor

@vy vy commented Jan 6, 2026

Back out java.lang.StringCoding changes delivered in JDK-8361842 (#25998 & 655dc51), which causes regressions reported in JDK-8374210.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374210: [BACKOUT] Move input validation checks to Java for java.lang.StringCoding intrinsics (Bug - P2)(⚠️ The fixVersion in this issue is [26] but the fixVersion in .jcheck/conf is 27, a new backport will be created when this pr is integrated.)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29055/head:pull/29055
$ git checkout pull/29055

Update a local copy of the PR:
$ git checkout pull/29055
$ git pull https://git.openjdk.org/jdk.git pull/29055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29055

View PR using the GUI difftool:
$ git pr show -t 29055

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29055.diff

Using Webrev

Link to Webrev Comment

@vy
Copy link
Contributor Author

vy commented Jan 6, 2026

Tier 1-3 are clear on c8acc80.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 6, 2026

👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 6, 2026

@vy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374210: [BACKOUT] Move input validation checks to Java for java.lang.StringCoding intrinsics

Reviewed-by: shade, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@vy vy changed the title [BACKOUT] Move input validation checks to Java for java.lang.StringCoding intrinsics 8374523: [BACKOUT] Move input validation checks to Java for java.lang.StringCoding intrinsics Jan 6, 2026
@openjdk openjdk bot added security security-dev@openjdk.org nio nio-dev@openjdk.org hotspot hotspot-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jan 6, 2026
@openjdk
Copy link

openjdk bot commented Jan 6, 2026

@vy The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot
  • i18n
  • nio
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 6, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 6, 2026

Webrevs

@vy
Copy link
Contributor Author

vy commented Jan 6, 2026

Matching the labels with #25998 that this PR is reverting:

/label remove i18n,nio,security

@openjdk openjdk bot removed i18n i18n-dev@openjdk.org nio nio-dev@openjdk.org security security-dev@openjdk.org labels Jan 6, 2026
@openjdk
Copy link

openjdk bot commented Jan 6, 2026

@vy
The i18n label was successfully removed.

The nio label was successfully removed.

The security label was successfully removed.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look like a clean backout -- the incoming/outgoing line counts do not match against the original commit -- so extra caution is needed in reviews.

Apart from the inadverent (?) addition in JavaLangAccess.java, there seem to be hunk differences in some sun/nio/cs files; I assume those are intentional?

@vy
Copy link
Contributor Author

vy commented Jan 6, 2026

there seem to be hunk differences in some sun/nio/cs files; I assume those are intentional?

Yes, they are clean reverts of the associated files changed in 655dc51.

@vy vy changed the title 8374523: [BACKOUT] Move input validation checks to Java for java.lang.StringCoding intrinsics 8374210: [BACKOUT] Move input validation checks to Java for java.lang.StringCoding intrinsics Jan 6, 2026
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 6, 2026
@vy
Copy link
Contributor Author

vy commented Jan 7, 2026

@TobiHartmann, @shipilev, thanks so much for your kind help, and reviews.
As I stated earlier, Tier 1-3 are clear using c8acc80, and I see no other remarks.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 7, 2026

Going to push as commit 7e18de1.
Since your change was applied there have been 30 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 7, 2026
@openjdk openjdk bot closed this Jan 7, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 7, 2026
@openjdk
Copy link

openjdk bot commented Jan 7, 2026

@vy Pushed as commit 7e18de1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vy vy deleted the sCodingBackout branch January 7, 2026 09:26
@vy
Copy link
Contributor Author

vy commented Jan 8, 2026

/backport :jdk26

@openjdk
Copy link

openjdk bot commented Jan 8, 2026

@vy the backport was successfully created on the branch backport-vy-7e18de13-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 7e18de13 from the openjdk/jdk repository.

The commit being backported was authored by Volkan Yazici on 7 Jan 2026 and was reviewed by Aleksey Shipilev and Tobias Hartmann.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-vy-7e18de13-jdk26:backport-vy-7e18de13-jdk26
$ git checkout backport-vy-7e18de13-jdk26
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-vy-7e18de13-jdk26

⚠️ @vy You are not yet a collaborator in my fork openjdk-bots/jdk. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants