-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8374210: [BACKOUT] Move input validation checks to Java for java.lang.StringCoding intrinsics #29055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tringCoding intrinsics" This reverts commit 655dc51.
|
Tier 1-3 are clear on c8acc80. |
|
👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into |
|
@vy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@vy The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
|
Matching the labels with #25998 that this PR is reverting: /label remove i18n,nio,security |
|
@vy The The |
shipilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not look like a clean backout -- the incoming/outgoing line counts do not match against the original commit -- so extra caution is needed in reviews.
Apart from the inadverent (?) addition in JavaLangAccess.java, there seem to be hunk differences in some sun/nio/cs files; I assume those are intentional?
Yes, they are clean reverts of the associated files changed in 655dc51. |
TobiHartmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
@TobiHartmann, @shipilev, thanks so much for your kind help, and reviews. /integrate |
|
Going to push as commit 7e18de1.
Your commit was automatically rebased without conflicts. |
|
/backport :jdk26 |
|
@vy the backport was successfully created on the branch backport-vy-7e18de13-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk: |
Back out
java.lang.StringCodingchanges delivered in JDK-8361842 (#25998 & 655dc51), which causes regressions reported in JDK-8374210.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29055/head:pull/29055$ git checkout pull/29055Update a local copy of the PR:
$ git checkout pull/29055$ git pull https://git.openjdk.org/jdk.git pull/29055/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29055View PR using the GUI difftool:
$ git pr show -t 29055Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29055.diff
Using Webrev
Link to Webrev Comment