8374577: Heap dump from core does not contain HPROF_GC_ROOT_JAVA_FRAME

[YaSuenag]

We can extract heap dump from coredump with jhsdb jmap --binaryheap, but it does not contain HPROF_GC_ROOT_JAVA_FRAME. It means we cannot detect leaked object on thread stack.

I attached 2 images which I saw on Eclipse Memory Analyzer Tool (MAT). Heap dumps were created following options:

-Xmx256m -XX:+CrashOnOutOfMemoryError -XX:+HeapDumpOnOutOfMemoryError

This image shows "thread overview" from the heapdump by -XX:+HeapDumpOnOutOfMemoryError. It reports OOME.main has large retained heap.

On the other hand, this image extracted by jhsdb jmap --binaryheap does not report it - leaked object is reported as unreachable objects.

heapDump.cpp in HotSpot dumps HPROF_GC_ROOT_JAVA_FRAME for each Java frames. SA should do that.

Essensially, we need to apply the fix in 290c5ba , however it fails with exception due to access oop in out of range. We need to fix the number of objects in expression stack like HotSpot. I fixed it in 0697df1 . And also I saw error relates to invokedynamic because ConstantPool in SA has not followed curre t HotSpot implementation. So I fixed it in a9c9e6c .

This change works fine with both interpreter and -Xcomp.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8374577: Heap dump from core does not contain HPROF_GC_ROOT_JAVA_FRAME (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29058/head:pull/29058
$ git checkout pull/29058

Update a local copy of the PR:
$ git checkout pull/29058
$ git pull https://git.openjdk.org/jdk.git pull/29058/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29058

View PR using the GUI difftool:
$ git pr show -t 29058

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29058.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@YaSuenag The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

@YaSuenag hotspot-gc has been added to this pull request based on files touched in new commit(s).

[YaSuenag]

/label remove hotspot-gc

[openjdk]

@YaSuenag
The hotspot-gc label was successfully removed.

[mlbridge]

Webrevs

• 01: Full - Incremental (12bb02db)
• 00: Full (a9c9e6c9)

[lmesnik]

@YaSuenag Can you please add/update jtreg test for this fix or explain in the bug/PR why it is not added.

[YaSuenag]

@lmesnik
I added the test to ClhsdbDumpheap.java whether HPROF_GC_ROOT_JAVA_FRAME is included in heap dump.