8374051: Incorrect parameterized testing of exceptions in AbstractDateTimeTest.java

[justin-curtis-lu]

Discovered in #28911, two test methods in the base test class AbstractDateTimeTest.java were not testing all the TemporalAccessors from samples() correctly. This PR updates the test methods to become parametrized so that their assertions do not exit early.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8374051: Incorrect parameterized testing of exceptions in AbstractDateTimeTest.java (Bug - P4)

Reviewers

• Naoto Sato (@naotoj - Reviewer)
• Roger Riggs (@RogerRiggs - Reviewer) Review applies to 9076b88a

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29071/head:pull/29071
$ git checkout pull/29071

Update a local copy of the PR:
$ git checkout pull/29071
$ git pull https://git.openjdk.org/jdk.git pull/29071/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29071

View PR using the GUI difftool:
$ git pr show -t 29071

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29071.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374051: Incorrect parameterized testing of exceptions in AbstractDateTimeTest.java

Reviewed-by: naoto, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• dd20e91: 8374521: Support fine-grained native debug levels
• 640343f: 8373724: Assertion failure in TestSignumVector.java with UseAPX
• 3541bc8: 8373538: Migrate all tests to null-safe "SimpleSSLContext" methods
• ... and 12 more: https://git.openjdk.org/jdk/compare/53300b4ac12240ea08227386412bfb90650c0aee...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@justin-curtis-lu The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (b3237311)
• 00: Full (9076b88a)

[naotoj]

By taking the opportunity, I think it is better to make valid tests that for-loop samples() values parameterized too.

[naotoj]

cosmetic: the blank line may better fit after junit imports

[justin-curtis-lu]

b323731 makes the rest of the eligible tests parameterized. After doing so, there was a test failure because some of the test class implementations provide values (which are instance variables) to samples() that are set during the @beforeEach methods. However, if the parametrized arguments are resolved before the value is set during the @beforeEach then it may be null during the test and fail.

To address this, the samples() methods were updated to use the tested values directly, rather than the re-usable instance variable.

[RogerRiggs]

looks good.

[naotoj]

LGTM. Also good to see those fail() going away

[justin-curtis-lu]

Thanks for the reviews.
/integrate

[openjdk]

Going to push as commit 1342db0.
Since your change was applied there have been 38 commits pushed to the master branch:

• 8212993: 8374540: Add comment describing implementation choices of Math.fma
• 9fd86e3: 8374639: Static archive with AOTClassLinking breaks dynamic archive
• 1fb5030: 8374767: Amend JDK-8374521 with new option name
• ... and 35 more: https://git.openjdk.org/jdk/compare/53300b4ac12240ea08227386412bfb90650c0aee...master

Your commit was automatically rebased without conflicts.

[openjdk]

@justin-curtis-lu Pushed as commit 1342db0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.