8374658: Consider use of "included" rather than "enclosed" in jx.a.p.Processor

[jddarcy]

The use of "enclosed" in javax.annotation.processing.Processor looks to be using a more colloquial definition than the JLS-eque notion of "enclosed" used in parts of the javax.lang.model API.

Instead, this PR proposes to switch from "enclosed" to "included," a term already used in RoundEnvironment for the concept in question.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8374660 to be approved

Issues

• JDK-8374658: Consider use of "included" rather than "enclosed" in jx.a.p.Processor (Enhancement - P4)
• JDK-8374660: Consider use of "included" rather than "enclosed" in jx.a.p.Processor (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29076/head:pull/29076
$ git checkout pull/29076

Update a local copy of the PR:
$ git checkout pull/29076
$ git pull https://git.openjdk.org/jdk.git pull/29076/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29076

View PR using the GUI difftool:
$ git pr show -t 29076

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29076.diff

Using Webrev

Link to Webrev Comment

[jddarcy]

The use of "enclosed" in javax.annotation.processing.Processor looks to be using a more colloquial definition than the JLS-eque notion of "enclosed" used in parts of the javax.lang.model API.

Instead, this PR proposes to switch from "enclosed" to "included," a term already used in RoundEnvironment for the concept in question.

Once there is agreement on the details of the wording changes, I'll file the CSR, etc.

[bridgekeeper]

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@jddarcy The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1b33c51a)

[jddarcy]

I'll re-flow the paragraph once the wording is agree to; n the initial iteration I wanted to make clear what exactly was changing -- replacing "enclosed" with a link to a method implementing the "included" definition.

[liach]

RoundEnviroment uses:

Only package elements, module elements, and type elements included in this round of annotation processing, or declarations of members, constructors, parameters, type parameters, or record components declared within those, are returned.

I would recommend consistency, that we update "enclosed within" to "declared within" or update RoundEnvironment, while the other "enclosed" to "included" look good.