-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8374767: Amend JDK-8374521 with new option name #29108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8374767: Amend JDK-8374521 with new option name #29108
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
RealCLanger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct.
|
S390X build failure is due to #29109 |
|
Thanks for reviews, here we go. /integrate |
|
Going to push as commit 1fb5030.
Your commit was automatically rebased without conflicts. |
During JDK-8374521 review we agreed on the new option name, but I forgot to push the commit that actually does it! So we integrated JDK-8374521 with older option name. This should amend the change with proper option name.
The options are now:
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29108/head:pull/29108$ git checkout pull/29108Update a local copy of the PR:
$ git checkout pull/29108$ git pull https://git.openjdk.org/jdk.git pull/29108/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29108View PR using the GUI difftool:
$ git pr show -t 29108Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29108.diff
Using Webrev
Link to Webrev Comment