8335801: [11u] Backport of 8210988 to 11u removes gcc warnings #2838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backport of 8210988 contained a number of issues, the most serious of which is it completely removed warnings from
gcc
builds by changingWARNING_CFLAGS_JDK
andWARNING_CFLAGS_JVM
, but not definingWARNINGS_ENABLE_ALL
,WARNINGS_ENABLE_ADDITIONAL_JVM
andDISABLED_WARNINGS
.The other more minor issues are the silent inclusion of
-Wreorder
to clang builds (should be a backport of JDK-8208672) and-xc99=%none
(reverting JDK-8215296), because new lines were used as is without comparing differences in what was being replaced.All three of these changes show up clearly when comparing the 11u & 12u changesets, and are corrected by this patch.
I can also confirm this has the desired effect with warnings as my local build on GCC 13 now fails again, whereas it was passing before (we need some backports there to make that work)
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2838/head:pull/2838
$ git checkout pull/2838
Update a local copy of the PR:
$ git checkout pull/2838
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2838/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2838
View PR using the GUI difftool:
$ git pr show -t 2838
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2838.diff
Webrev
Link to Webrev Comment