Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320675: PrinterJob/SecurityDialogTest.java hangs #2912

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Aug 15, 2024

I backport this for parity with 11.0.25-oracle.
modify lines are different, but code is clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320675 needs maintainer approval

Issue

  • JDK-8320675: PrinterJob/SecurityDialogTest.java hangs (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2912/head:pull/2912
$ git checkout pull/2912

Update a local copy of the PR:
$ git checkout pull/2912
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2912/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2912

View PR using the GUI difftool:
$ git pr show -t 2912

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2912.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 15, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 15, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9f5ad43358a4e209b4cd1c91bcc86b997f371548 8320675: PrinterJob/SecurityDialogTest.java hangs Aug 15, 2024
@openjdk
Copy link

openjdk bot commented Aug 15, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 15, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 15, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 15, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants