Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout #2919

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Aug 22, 2024

Hi all,

This pull request contains a backport of commit f132b347 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade.

This PR not clean, because this file has changed by JDK-8328638 and JDK-8329213 which not backported to jdk11u-dev.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336854 needs maintainer approval

Issue

  • JDK-8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2919/head:pull/2919
$ git checkout pull/2919

Update a local copy of the PR:
$ git checkout pull/2919
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2919/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2919

View PR using the GUI difftool:
$ git pr show -t 2919

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2919.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@sendaoYan
Copy link
Member Author

/approval request Clean backport, to fix the test bug, trivial fix, no risk.

@openjdk
Copy link

openjdk bot commented Aug 22, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport f132b347e13a57d9654f0ab11db0636999576036 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout Aug 22, 2024
@openjdk
Copy link

openjdk bot commented Aug 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 22, 2024
@openjdk
Copy link

openjdk bot commented Aug 22, 2024

@sendaoYan
8336854: The approval request has been created successfully.

@mlbridge
Copy link

mlbridge bot commented Aug 22, 2024

Webrevs

@openjdk openjdk bot added the approval label Aug 22, 2024
@sendaoYan
Copy link
Member Author

sendaoYan commented Aug 27, 2024

GHA report macos-x64 and macos-aarch64 build failed. The build failed issue has been recorded by JDK-8299635 and is fixing by #2844. The failures unreleated to this PR.

@phohensee
Copy link
Member

I believe you meant "unrelated to this PR". :)

@sendaoYan
Copy link
Member Author

I believe you meant "unrelated to this PR". :)

Sorry for the typo. The typo has been corrected.

@sendaoYan
Copy link
Member Author

Before this PR has been reviewed, the approval label should not be seted.
/approval cancel

@openjdk
Copy link

openjdk bot commented Aug 29, 2024

@sendaoYan
8336854: The approval request has been cancelled successfully.

@openjdk openjdk bot removed the approval label Aug 29, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 26, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/open

@openjdk
Copy link

openjdk bot commented Sep 27, 2024

@sendaoYan This pull request is already open

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/open

@openjdk
Copy link

openjdk bot commented Oct 25, 2024

@sendaoYan This pull request is already open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants