Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303920: Avoid calling out to python in DataDescriptorSignatureMissing test #2922

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cost0much
Copy link

@cost0much cost0much commented Aug 26, 2024

Clean backport that improves DataDescriptorSignatureMissing test; already backported to 17 and 21. Passes affected test in Linux x64.
MacOS GHA failing due to unrelated deprecated code during compile


Progress

  • Change must not contain extraneous whitespace
  • JDK-8303920 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8303920: Avoid calling out to python in DataDescriptorSignatureMissing test (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2922/head:pull/2922
$ git checkout pull/2922

Update a local copy of the PR:
$ git checkout pull/2922
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2922/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2922

View PR using the GUI difftool:
$ git pr show -t 2922

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2922.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2024

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 26, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 79349b8bb30e3a358a1fec2382d44aabcf15239b 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test Aug 26, 2024
@openjdk
Copy link

openjdk bot commented Aug 26, 2024

This backport pull request has now been updated with issue from the original commit.

@cost0much
Copy link
Author

/approval request Improves the test DataDescriptorSignatureMissing added in JDK22. Applies cleanly. Affected test passes. Risk is low: the change is test code only.

@openjdk
Copy link

openjdk bot commented Aug 26, 2024

@cost0much
8303920: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Aug 26, 2024
@cost0much cost0much marked this pull request as ready for review August 26, 2024 21:01
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 26, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 26, 2024

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Aug 27, 2024

There are failed tests.

@openjdk
Copy link

openjdk bot commented Aug 27, 2024

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot removed the approval label Aug 27, 2024
@phohensee
Copy link
Member

MacOS GHA build failures are sprintf related, i.e., unrelated to this backport.

@cost0much
Copy link
Author

/approval request Improves the test DataDescriptorSignatureMissing added in JDK22. Applies cleanly. Affected test passes and failing GHA is unrelated to the backport. Risk is low: the change is test code only.

@openjdk
Copy link

openjdk bot commented Aug 27, 2024

@cost0much
8303920: The approval request has been updated successfully.

@openjdk openjdk bot added the approval label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants