Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338402: GHA: some of bundles may not get removed #2931

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Sep 2, 2024

Backport fixing problem, where some bundles may not get removed in GHA.

GHA testing: OK (no leftover bundles, MacOS failures are unrelated)


Progress

  • JDK-8338402 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8338402: GHA: some of bundles may not get removed (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2931/head:pull/2931
$ git checkout pull/2931

Update a local copy of the PR:
$ git checkout pull/2931
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2931/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2931

View PR using the GUI difftool:
$ git pr show -t 2931

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2931.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2024

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 2, 2024

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8338402: GHA: some of bundles may not get removed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport d8e4d3f2d6c187f2487acd390a4e5fa2a99010ea 8338402: GHA: some of bundles may not get removed Sep 2, 2024
@openjdk
Copy link

openjdk bot commented Sep 2, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 2, 2024

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 2, 2024
@zzambers
Copy link
Contributor Author

zzambers commented Sep 2, 2024

/approval request Fix to GHA code which removes bundle artifacts, only affects testing in GHA, tested

@openjdk
Copy link

openjdk bot commented Sep 2, 2024

@zzambers
8338402: The approval request has been created successfully.

@mlbridge
Copy link

mlbridge bot commented Sep 2, 2024

Webrevs

@openjdk openjdk bot added the approval label Sep 2, 2024
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 30, 2024
@zzambers
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 30, 2024
@openjdk
Copy link

openjdk bot commented Sep 30, 2024

@zzambers
Your change (at version a123266) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 30, 2024

Going to push as commit 2232d1f.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 06d87ca: 8299254: Support dealing with standard assert macro
  • 0157967: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
  • bec83f3: 8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java
  • 59b3859: 8340815: Add SECURITY.md file
  • dd35f18: 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1
  • b2d3859: Merge
  • 0358cbd: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2
  • 934decc: Merge
  • 90ad5b1: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
  • 6ee8bac: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods
  • ... and 12 more: https://git.openjdk.org/jdk11u-dev/compare/3caf5017a11ba0777281c0104dc606873947c615...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 30, 2024
@openjdk openjdk bot closed this Sep 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 30, 2024
@openjdk
Copy link

openjdk bot commented Sep 30, 2024

@shipilev @zzambers Pushed as commit 2232d1f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants