-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8338402: GHA: some of bundles may not get removed #2931
8338402: GHA: some of bundles may not get removed #2931
Conversation
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
@zzambers This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Fix to GHA code which removes bundle artifacts, only affects testing in GHA, tested |
/integrate |
/sponsor |
Going to push as commit 2232d1f.
Your commit was automatically rebased without conflicts. |
Backport fixing problem, where some bundles may not get removed in GHA.
GHA testing: OK (no leftover bundles, MacOS failures are unrelated)
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2931/head:pull/2931
$ git checkout pull/2931
Update a local copy of the PR:
$ git checkout pull/2931
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2931/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2931
View PR using the GUI difftool:
$ git pr show -t 2931
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2931.diff
Webrev
Link to Webrev Comment