-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8195675: Call to insertText with single character from custom Input Method ignored #2971
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back srl! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
/approval request java.awt components did not work properly on macOS with custom input methods, the net effect is that minority language keyboards did not work properly with Java. Low risk, the fix handles this situation similarly to how Apple's own 'kotoeri' input method was handled on a long term basis, so it is a well-worn path. Patch should apply cleanly and was code reviewed |
|
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2971/head:pull/2971
$ git checkout pull/2971
Update a local copy of the PR:
$ git checkout pull/2971
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2971/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2971
View PR using the GUI difftool:
$ git pr show -t 2971
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2971.diff
Webrev
Link to Webrev Comment