Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6355567: AdobeMarkerSegment causes failure to read valid JPEG #2977

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

midver
Copy link

@midver midver commented Oct 18, 2024

Backport of JDK-6355567: AdobeMarkerSegment causes failure to read valid JPEG

Fixes bug that can occur when reading JPEG files with Adobe-specific JPEG application markers.

Tier 1 tests were successful. New regression test fails without this fix but passes with it.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-6355567 needs maintainer approval

Error

 ⚠️ OCA signatory status must be verified

Warning

 ⚠️ Patch contains a binary file (test/jdk/javax/imageio/plugins/jpeg/jdk_6355567.jpg)

Issue

  • JDK-6355567: AdobeMarkerSegment causes failure to read valid JPEG (Bug - P4) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2977/head:pull/2977
$ git checkout pull/2977

Update a local copy of the PR:
$ git checkout pull/2977
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2977/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2977

View PR using the GUI difftool:
$ git pr show -t 2977

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2977.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Oct 18, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2024

Hi @midver, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user midver" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Oct 18, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oca Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

1 participant