Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338751: ConfigureNotify behavior has changed in KWin 6.2 #2981

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zzag
Copy link

@zzag zzag commented Oct 21, 2024

Reviewed-by: prr, azvegint, serb


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8338751 needs maintainer approval

Issue

  • JDK-8338751: ConfigureNotify behavior has changed in KWin 6.2 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2981/head:pull/2981
$ git checkout pull/2981

Update a local copy of the PR:
$ git checkout pull/2981
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2981/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2981

View PR using the GUI difftool:
$ git pr show -t 2981

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2981.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2024

👋 Welcome back zzag! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 21, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 3da68900818fc43b777098fe6e244779794d5294 8338751: ConfigureNotify behavior has changed in KWin 6.2 Oct 21, 2024
@openjdk
Copy link

openjdk bot commented Oct 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 21, 2024

⚠️ @zzag This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 21, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 21, 2024

Webrevs

@zzag
Copy link
Author

zzag commented Oct 21, 2024

/approval request This is needed to properly fix placement issues with popups in Plasma 6.2 (and likely other issues caused by having wrong global coordinates). 6.2.1 contains a workaround, but it doesn't cover all cases. This should be a safe to backport fix.

@openjdk
Copy link

openjdk bot commented Oct 21, 2024

@zzag
8338751: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant