Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+ #3009

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tkiriyama
Copy link
Contributor

@tkiriyama tkiriyama commented Oct 28, 2024

Hi all,
This pull request is the backport of JDK-8310072.
It is clean and change only DisabledComboBoxFontTestAuto.java. This change resolves a test failure added by the JDK-7093691.
JDK-7093691will be backported in #3008.

Testing:
javax/swing/JComboBox on Windows and Linux


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8310072 needs maintainer approval

Issue

  • JDK-8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+ (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3009/head:pull/3009
$ git checkout pull/3009

Update a local copy of the PR:
$ git checkout pull/3009
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3009/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3009

View PR using the GUI difftool:
$ git pr show -t 3009

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3009.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2024

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport eb60822a45ecd076484e707b2dd1049ed9d8079b 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+ Oct 28, 2024
@openjdk
Copy link

openjdk bot commented Oct 28, 2024

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

mlbridge bot commented Oct 28, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant