Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313633: [macOS] java/awt/dnd/NextDropActionTest/NextDropActionTest.java fails with java.lang.RuntimeException: wrong next drop action! #3224

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 17, 2025

I backport this for parity with 17.0.15-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8313633 needs maintainer approval

Issue

  • JDK-8313633: [macOS] java/awt/dnd/NextDropActionTest/NextDropActionTest.java fails with java.lang.RuntimeException: wrong next drop action! (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3224/head:pull/3224
$ git checkout pull/3224

Update a local copy of the PR:
$ git checkout pull/3224
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3224/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3224

View PR using the GUI difftool:
$ git pr show -t 3224

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3224.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 17, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313633: [macOS] java/awt/dnd/NextDropActionTest/NextDropActionTest.java fails with java.lang.RuntimeException: wrong next drop action!

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 2d29e1b: 8316696: Remove the testing base classes: IntlTest and CollatorTest
  • 9db8d28: 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754
  • 18f7669: 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information
  • 6a5aaaa: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready
  • 2b8c19a: 8309740: Expand timeout windows for tests in JDK-8179502
  • 25c7a7b: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport d97de8260c19e468c87221e28f29128e56ec8ee1 8313633: [macOS] java/awt/dnd/NextDropActionTest/NextDropActionTest.java fails with java.lang.RuntimeException: wrong next drop action! Jan 17, 2025
@openjdk
Copy link

openjdk bot commented Jan 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 17, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 17, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 17, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jan 18, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Jan 20, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 20, 2025

Going to push as commit d3adb1e.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 2a7f57a: 8294067: [macOS] javax/swing/JComboBox/6559152/bug6559152.java Cannot select an item from popup with the ENTER key.
  • 7d69b6a: 8282314: nsk/jvmti/SuspendThread/suspendthrd003 may leak memory
  • d2fb8c2: 8311546: Certificate name constraints improperly validated with leading period
  • 2d29e1b: 8316696: Remove the testing base classes: IntlTest and CollatorTest
  • 9db8d28: 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754
  • 18f7669: 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information
  • 6a5aaaa: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready
  • 2b8c19a: 8309740: Expand timeout windows for tests in JDK-8179502
  • 25c7a7b: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 20, 2025
@openjdk openjdk bot closed this Jan 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 20, 2025
@openjdk
Copy link

openjdk bot commented Jan 20, 2025

@GoeLin Pushed as commit d3adb1e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant